Question

I have a friends page which pulls rows from a database, I only want to display the current users friends but it only returns the current user from the query.

Database Table:

Current Code:

function getFriends($user_id, $sqli_con) {
    $user_id = mysqli_escape_string($sqli_con, strip_tags($user_id));

    $results = $sqli_con->query("SELECT * FROM friends WHERE receiver_id = '$user_id' AND accepted = '1' OR sender_id = '$user_id' AND accepted = '1'");

    if($results->num_rows > 0) {

        while($row = $results->fetch_array(MYSQLI_ASSOC)) {
            if($row['receiver_id'] === $user_id || $row['sender_id'] === $user_id) {

            } else {
                $username_stmt = $sqli_con->prepare("SELECT id, username FROM members WHERE id = {$row['receiver_id']} OR id = {$row['sender_id']}");
                $username_stmt->execute();
                $username_stmt->store_result();
                $username_stmt->bind_result($id, $username);
                $username_stmt->fetch();
                $username_stmt->close();
                $results->free();

                return "

                    <div id='friend'>
                        <a href='profile.php?id=".$id."'><img src='". getProfileImagePath($id, $sqli_con) . "' /></a>
                        <a href='profile.php?id=".$id."'>". $username . "</a>
                    </div>

                ";
            }

        }

    } else {
        $results->free();
        return "You don't have any friends yet! :( Why not search for some?";
    }
}

Currently no results are returned but if I take out the user id check it only returns the current user.

EDIT:
I got it working, solution:

function getFriends($user_id, $sqli_con) {
    $user_id = mysqli_escape_string($sqli_con, strip_tags($user_id));

    $results = $sqli_con->query("SELECT * FROM friends WHERE (receiver_id = '$user_id' OR sender_id = '$user_id') AND accepted = '1'");

    if($results->num_rows > 0) {

        while($row = $results->fetch_array(MYSQLI_ASSOC)) {
            if($row['sender_id'] !== $user_id) {
                $username_stmt = $sqli_con->prepare("SELECT username FROM members WHERE id = {$row['sender_id']}");
                $username_stmt->execute();
                $username_stmt->store_result();
                $username_stmt->bind_result($username);
                $username_stmt->fetch();
                $username_stmt->close();

                echo "

                    <div id='friend'>
                        <a href='profile.php?id=".$row['sender_id']."'><img src='". getProfileImagePath($row['sender_id'], $sqli_con) . "' /></a>
                        <a href='profile.php?id=".$row['sender_id']."'>". $username . "</a>
                    </div>

                ";
            }
            if($row['receiver_id'] !== $user_id) {
                $username_stmt = $sqli_con->prepare("SELECT username FROM members WHERE id = {$row['receiver_id']}");
                $username_stmt->execute();
                $username_stmt->store_result();
                $username_stmt->bind_result($username);
                $username_stmt->fetch();
                $username_stmt->close();

                echo "

                    <div id='friend'>
                        <a href='profile.php?id=".$row['receiver_id']."'><img src='". getProfileImagePath($row['receiver_id'], $sqli_con) . "' /></a>
                        <a href='profile.php?id=".$row['receiver_id']."'>". $username . "</a>
                    </div>

                ";
            }
        }

    } else {
        $results->free();
        return "You don't have any friends yet! :( Why not search for some?";
    }
}

Not pretty but it’ll do. Thanks for the help guys.(Tested with multiple entries and it works)

Answer 1

You returned from within the loop. Try something like:

$result_string = '';
// the loop definition here
$result_string .= "<div id='friend'>
                        <a href='profile.php?id=".$id."'><img src='". getProfileImagePath($id, $sqli_con) . "' /></a>
                        <a href='profile.php?id=".$id."'>". $username . "</a>
                   </div>";
// closing the loop
return $result_string;