Question

I have a function to convert from one image representation (MyImage) to a QImage, and I decided it would be tidier to dedicate a namespace to functions that interface in this manner. I previously had this function directly in the class representing my main QMainWindow.

So, I created a file MyFormatToQtInterfacing.h which looks as follows:

#include <QtGui/QMainWindow>
#include <qlabel.h>

namespace MyFormatToQtInterfacing
{
    // These functions below convert a cv::Mat to a QImage.
    // Adapted from http://stackoverflow.com/questions/5026965/how-to-convert-an-opencv-cvmat-to-qimage
    // The grayscale ones seem to be inverted.  Look into this later.

    QImage MyImage2QImage(const MyImage &src) { //snip };
};

I then call the function from this new namespace, as you would expect, and I get the following linker error:

1>main.obj : error LNK2005: “class QImage _cdecl
MyFormatToQtInterfacing::Mat2QImage(class MyImage2QImage const &)”
(?MyImage2QImage@MyFormatToQtInterfacing@@YA?AVQImage@@ABV?$Mat@V?$Vec@E$02@cv@@@cv@@@Z)
already defined in moc_Tracker.obj

1>Tracker.obj : error LNK2005: “class QImage _cdecl
MyFormatToQtInterfacing::MyImage2QImage(class MyImage2QImage const &)”
(?MyImage2QImage@MyFormatToQtInterfacing@@YA?AVQImage@@ABV?$Mat@V?$Vec@E$02@cv@@@cv@@@Z)
already defined in moc_Tracker.obj

1>C:\Projects\Tracker\Tracker.exe : fatal error LNK1169: one or more
multiply defined symbols found

I’ve also been subbing out MyImage with OpenCV matrices and getting the same problem. Why is this happening and how can I resolve it?

Answer 1

You are falling afoul of the one definition rule. You are not allowed to define non inline or non template functions in headers that are included in multiple compilation units. Move your definition to a .cpp file or mark the function as inline.