Question

I have a java web application that I removed a function from the code and yet the database entries that this function writes are still being written to the database.

Inside the IssueWarrant function there is a call to insertWarrantFee that has been commented out.

private void issueWarrant(String CasePrefix, String CaseNumber, String HearingType, String Suspend)
    {
        int i = 0, intDivision = 0, pos = 0;
        String SummSeq = getSummSeq(CasePrefix, CaseNumber);
        String Charges = getCharges(CasePrefix, CaseNumber, HearingType);
        boolean isVacated = false, isHearingFound = false;
        NextBWNumber warrNbr = new NextBWNumber();
        String WarrantNumber = warrNbr.getNextBWNumber();
        String warrStatus = warrNbr.getNextBWNStatus();
        String HearingDesc = "", Division = "";
        isVacated = getVacatedStatus(CasePrefix, CaseNumber, HearingType);
        isHearingFound = getHearingStatus (CasePrefix, CaseNumber, HearingType);

        HearingDesc = getFormatToday() + "  " + getHearingDesc(HearingType);
        if (HearingDesc.length() > 30)
        {
            HearingDesc = HearingDesc.substring(0,30);
        }
        Division = getHearingJudge(CasePrefix,CaseNumber,HearingType);
        intDivision = Integer.parseInt(Division);
        if (intDivision < 10)
        { Division = "0" + Division; }

        Statement localstmt = null;
        String localqueryString;

        localqueryString = "INSERT INTO " + library7 + "CMPBWPND" +
            " (CASPRE, CASNUM, DEFSEQ, CHGSEQ, SUMSEQ, STSCOD, STSDAT," +
            " STATUT, CHGABV, BWNBR, JUDCOD, PRVFLG, CT2FLG, DIVISN, BNDAMT," +
            " BTYPE, CMNT, CUSER, TUSER, LUPDAT, SCRDAT, STATSDAT, SUMCRDAT, LUPDATE )" +
            " VALUES ('" + CasePrefix + "', " + CaseNumber + ", 1, " + Charges.substring(i, i + 1) +
            ", " + SummSeq + ", 9, " + getShortDate() + ", 'RCP 12-A TA', 'WARRANT', '" +
            WarrantNumber + "', " + intDivision + ", 'N', 1, '" + Division + "', " +
            BondAmt + ", '" + BondType +  "', '" + HearingDesc + "', 'TAAD', 'TAAD', " +
            getShortDate() + ", " + getShortDate() + ", " + getLongDate() + ", " + getLongDate() +
            ", " + getLongDate() + ")"; 

        try
        {
            if (!isVacated && isHearingFound)
            {
                localstmt = conn.createStatement();
                localstmt.executeUpdate(localqueryString);
                localstmt.close();
                StatusMsg = "Client No Show-WI";
            }
            if (isVacated)
            {
                StatusMsg = "Client Vacated Case";
            }
            if (!isHearingFound)
            {
                StatusMsg = "Client Hearing Missing";
            }

        } catch (SQLException e)
            {
                System.out.println("IssueWarr - Error in IssueWarrant");
                e.printStackTrace();
                ReturnInfo = "Issuing Warrants Failed.";
                success = false;
            }finally
            {
                try
                {
                    if (!localstmt.isClosed())
                    {
                        localstmt.close();
                    }                   
                } catch (SQLException sql2)
                    {
                        System.out.println("Error trying to close connections. Exception: " +  sql2.getMessage());
                    }
            }

        **//insertWarrantFee(CasePrefix, CaseNumber, SummSeq, WarrantNumber);**     
        updateHearingRecord(CasePrefix, CaseNumber, HearingType, Charges.substring(i, i + 1), Suspend);

        for ( i = 1; i < Charges.length(); i++ )
        {
            insertBWPTFRecord(CasePrefix, CaseNumber, SummSeq, Charges.substring(i, i + 1));
        }
        if (!success)
        {
            StatusMsg = "Client Iss. Warrant Failure";
        }
    }

Here is the code that the insertWarrantFee called before it was commented out:

private void insertWarrantFee(String CasePrefix, String CaseNumber, String SummSeq, String WarrantNumber)
    {
        Statement localstmt = null;
        String localqueryString;
        ResultSet localrSet = null;
        String feeAmt = null;

        localqueryString = "SELECT AUTO$$ FROM " + library3 + "CMPDKTTP WHERE DKTTYP = 'W'";
        try
        {
            localstmt = conn.createStatement();
            localrSet = localstmt.executeQuery(localqueryString);         
            while (localrSet.next())
            {
                feeAmt = localrSet.getString("AUTO$$");
            }
            localstmt.close();
            localrSet.close();

        } catch (SQLException e)
            {
                System.out.println("IssueWarr - Error in Insert Warrant Fee SQL1");
                e.printStackTrace();
                ReturnInfo = "Issuing Warrants Failed.";
                success = false;
            }finally
            {
                try
                {
                    if (!localstmt.isClosed())
                    {
                        localstmt.close();
                    }                   
                } catch (SQLException sql2)
                    {
                        System.out.println("Error trying to close connections. Exception: " +  sql2.getMessage());
                    }
            }   

        localqueryString = "INSERT INTO " + library7 + "CMPBWTRN"
            + " (CASPRE, CASNUM, DEFSEQ, SUMSEQ, BWNBR, FEEAMT, DKTTYP, TUSER, LUPDAT)" 
            + " VALUES ('" + CasePrefix + "', " + CaseNumber + ", 1, " + SummSeq + ", '" + WarrantNumber
            + "', " + feeAmt + ", 'W', 'TAAD', " + getShortDate() + ")";                
        try
        {
            localstmt = conn.createStatement();
            localstmt.executeUpdate(localqueryString);
            localstmt.close();

        } catch (SQLException e)
            {
                System.out.println("IssueWarr - Insert Warrant Fee SQL2");
                e.printStackTrace();
                ReturnInfo = "Issuing Warrants Failed.";
                success = false;
            }finally
            {
                try
                {
                    if (!localstmt.isClosed())
                    {
                        localstmt.close();
                    }                   
                } catch (SQLException sql2)
                    {
                        System.out.println("Error trying to close connections. Exception: " +  sql2.getMessage());
                    }
            }
    }

So even though the line that called insertWarrantFee is commented out a record is still being inserted into CMPBWTRN.

Any ideas how this could happen? The developer is indicating it could be a tomcat connection cache issue? Any other suggestion beside magical code?

Thanks!
Leslie

Answer 1

A couple of things to try:

• Make sure you’ve redeployed the application and have restarted Tomcat. Check the timestamp of the deployed class in question.
• Clean Tomcat’s tmp and work directories
• Open the deployed Java class using a decompiler to see whether the removed code is still in there.
• Add a logging (or System.out.println) statement to the method that’s commented out, and to the method calling it. See whether one or both are printed after redeploying the changes.