Question

I have a javascript routine that is performing actions on a group of checkboxes, but the final action I want to set the clicked checkbox to checked or unchecked based on if the user was checking the box or unchecking.

Unfortunately, every time I check for whether it is being checked or unchecked, it returns ‘on’ indicating the user is always checking the box! Any help would be appreciated, I’ve also included the javascript.

// Uncheck all the checkboxs with the same Tax Credit for (i=0; i<arrChecks.length; i++) {     var attribute = arrChecks[i].getAttribute('xid')     if (attribute == elementName)     {         // if the current state is checked, unchecked and vice-versa         if (arrChecks[i].value == 'on')   // <-- This is always returning true, even if the box is being unchecked         {             arrChecks[i].checked = 1;         } else {             arrChecks[i].checked = 0;         }      } else {         arrChecks[i].checked = 0;     } }  

Answer 1

You should be evaluating against the checked property of the checkbox element.

for (i=0; i<arrChecks.length; i++) {     var attribute = arrChecks[i].getAttribute('xid')     if (attribute == elementName)     {         // if the current state is checked, unchecked and vice-versa         if (arrChecks[i].checked)         {             arrChecks[i].checked = false;         } else {             arrChecks[i].checked = true;         }      } else {         arrChecks[i].checked = false;     } }