Question

I have a lengthy query here, and wondering whether it could be refactor?

Declare @A1 as int
Declare @A2 as int
...
Declare @A50 as int

SET @A1 =(Select id from table where code='ABC1')
SET @A2 =(Select id from table where code='ABC2')
...
SET @A50 =(Select id from table where code='ABC50')

Insert into tableB
Select 
Case when @A1='somevalue' Then 'x' else 'y' End,
Case when @A2='somevalue' Then 'x' else 'y' End,
..

Case when @A50='somevalue' Then 'x' else 'y' End
From tableC inner join ......

So as you can see from above, there is quite some redundant code. But I can not think of a way to make it simpler.

Any help is appreciated.

Answer 1

If you need the variables assigned, you could pivot your table…

SELECT *
FROM 
(
SELECT Code, Id
FROM Table
) t
PIVOT
(MAX(Id) FOR Code IN ([ABC1],[ABC2],[ABC3],[ABC50])) p /* List them all here */
;

…and then assign them accordingly.

SELECT @A1 = [ABC1], @A2 = [ABC2]
FROM 
(
SELECT Code, Id
FROM Table
) t
PIVOT
(MAX(Id) FOR Code IN ([ABC1],[ABC2],[ABC3],[ABC50])) p /* List them all here */
;

But I doubt you actually need to assign them at all. I just can’t really picture what you’re trying to achieve.

Pivotting may help you, as you can still use the CASE statements.

Rob