Question

I have a Linq2Sql query that looks like this:

var data = from d in dc.GAMEs
    where (d.GAMEDATE + d.GAMETIME.Value.TimeOfDay) >= DateTime.Now
        && d.GAMESTAT == 'O' && d.GAMETYPE == 0 select d;

Resharper is underlining the “d.GAMETIME.Value.TimeOfDay” in blue and telling me it’s a possible System.InvalidOperationException. While I get that if it were C# code, referencing Value without checking if it has a value would be such, i’m not sure if that is true of a Linq query.

The actual SQL generated looks horrendous, and makes me want to burn my eyes out, but I see nothing that looks like it could be a null reference. Can I safely ignore this?

(ignore for the moment the other issues, such as if it returns the expected results)

EDIT:

Upon further thought, I can see how the above might cause an exception in a LinqToObjects query, and possibly other kinds (XML?). So yeah, I suppose Resharper is just being safe.

Answer 1

When dealing with expression trees (as this LINQ to SQL query) it totally depends on the LINQ provider used (in your case LINQ to SQL). Therefore, it is (almost) impossible for Resharper to say anything useful about your query. I think it just interprets this code as normal C# delegates. I would say it is safe to ignore, but perhaps add a comment for the next developer.