Question

I have a method that checks for achievements and I am trying to get it to work properly. It takes a String and converts it to a long and then checks against a String value in the database ( Which is converted to long )

here is the code:

public boolean checkAchievements(String timeString) {   
    long timeInt = Long.parseLong(timeString);
    boolean newAchievement = false;
    SQLiteDatabase db = this.getWritableDatabase();

    Cursor cursor = db.rawQuery("SELECT millis FROM records ORDER BY CAST(millis as SIGNED) DESC", null);
    cursor.moveToFirst();
    long topTime = Long.parseLong(cursor.getString(0));
    cursor.close();

    if (timeInt > topTime) {
        db.rawQuery("update achievements set completed='yes' where name='Beat top record'", null);
        newAchievement = true;
    }

    db.close();

    return newAchievement;
}

Ihe timeString is the current time in milliseconds grabbed from the calendar and converted into a string from a long. I have no idea why this function keeps returning true especially when i know for a fact that timeInt is not greater than topTime.

also, even though this function is returning true, that update query isn’t even running because i checked the database and the completed value is still “no” where name=”Beat top record”.

Answer 1

Your method is returning true which is correct as per the condition. Let me explain you in details.

as you said in question your timeString variable contains the current milliseconds which is a long value of milliseconds since 1st Jan 1900. Your time value in database is the old one than the current time ( i am assuming that, as you haven’t given its value in question ). So suppose you have top time is of yesterday ( i.e. 31st May 2012 ). Now when you compare this value with today’s current time, your method is going to return true which is correct itself.

for checking the false value i would like to suggest you to store some future time like greater than the today’s date ( i.e. 1st June 2012 ) and the execute the method, it will surely return false value.