Question

I have a method that finds all the controls, iterates through them, determines if they are a textbox,drop down list, etc.. retrieves their ID name, and depending on the ID name it will set a boolean statement (thus I would know if that section of the form is complete, and will email to a certain group of people) unfortunetly this is done with too many if statements and was wondering if I could get some help making this more manageable

protected void getEmailGroup()
{
    Control[] allControls = FlattenHierachy(Page);
    foreach (Control control in allControls)
    {
        if (control.ID != null)
        {
            if (control is TextBox)
            {
                TextBox txt = control as TextBox;
                if (txt.Text != "")
                {
                    if (control.ID.StartsWith("GenInfo_"))
                    {
                        GenInfo = true;
                    }
                    if (control.ID.StartsWith("EmpInfo_"))
                    {
                        EmpInfo = true;
                    }
                }
            }
            if (control is DropDownList)
            {
                DropDownList lb = control as DropDownList;
                if (lb.SelectedIndex != -1)
                {
                    if (control.ID.StartsWith("GenInfo_"))
                    {
                        GenInfo = true;
                    }
                    if (control.ID.StartsWith("EmpInfo_"))
                    {
                        EmpInfo = true;
                    }
                }
            }
        }
    }
}      

Answer 1

Instead of using the Lambda expression I have created a method that handles the control for me, and depending on the name of the control, it sets that section to be true

public bool setGroup(Control ctrl)
    {
        isAControl = false;

        //set a section to true, so it will pull the html
        if (ctrl.ID.StartsWith("GenInfo_"))
        {
            GenInfo = true;
            lstControls.Add(ctrl.ID.Replace("GenInfo_", ""));
            isAControl = true;
            return isAControl;
        }

here is a small snippet of my code I only want to check for certain controls(to speed things up) and I go through each control as each control has a different way to get the value (textbox would use .text where dropdownlist would use .selectedValue)

if(control is TextBox || control is DropDownList || control is RadioButton || control is RadioButtonList 
                || control is CheckBox || control is CheckBoxList)
                {
                    if (control is TextBox)
                    {
                        TextBox txt = control as TextBox;
                        if (txt.Text != "" && txt.Text != "YYYY/MM/DD")
                        {
                            setGroup(control);
                            if (isAControl)
                            {
                                string controlNoGroup = lstControls.Last();
                                strHtml = strHtml.Replace("@" + (controlNoGroup.ToString()) + "@", txt.Text);
                            }
                        }
                    }