Question

I have a model who holds 2 properties: valid_from and valid_to.

I need to select all instances that are currently valid, i.e. valid_from <= today and valid_to >= today.

i have the following find :

Mymodel.find(:all, :conditions => ["valid_from <= ? and valid_to >= ?", Date.today, Date.today])

I already thought about storing Date.today in a variable and calling that variable, but i still need to call it twice.

my_date = Date.today
Mymodel.find(:all, :conditions => ["valid_from <= ? and valid_to >= ?", my_date, my_date])

Is there a way to improve and do only one call to the variable to match all the “?” in the :conditions ?

thanks,
P.

Answer 1

I would use named_scope. In model add:

named_scope :valid, 
            :conditions => 
             ["valid_from <= ? and valid_to >= ?", Date.today, Date.today]

And then in your controller you can call:

@mymodels = Mymodel.valid

I think that focusing on reducing two calls to Date.today to only one call is wasting of time. It won’t make your application faster or using less memory.