Question

I have a page with search form on it and table with search results below. In search form i have checkbox “Search in this category”. What i’m doing to check it by default :

if(!isset($_SESSION['inthiscat'])){
    $_SESSION['inthiscat'] = 'on' ;
    $checked = 'checked';
}
$_GET['inthiscat'] = $_SESSION['inthiscat'];

checkbox code : INPUT type=”checkbox” name=”inthiscat”<?=$checked?>.
Link to next page of results index.php?inthiscat=$_GET[‘inthiscat’].
So the problem is when i uncheck “Search in this category” its still checked when i going to next page of results. How to fix it and what i’m doing wrong? Session startet of course.

Answer 1

Firstly, do you really need SESSION variables for this? If you want box to be checked when GET parameter is not specified, you do not need SESSIONs at all.

Assuming you want to preserve the behaviour in case someone removes the GET parameter:

<?php
session_start();
//......
//......
$checked='checked';
if(isset($_REQUEST['inthiscat'])) {
   // Form input and url GET parameters take precedence
   if($_REQUEST['inthiscat'] != 'checked') { $checked = ''; };
} else if(isset($_SESSION['inthiscat'])) { 
   // Next, use session variable if it exists
   if($_SESSION['inthiscat'] != 'checked') { $checked = ''; };
};
$_SESSION['inthiscat']=$checked;
?>

Note:

1) Assigning values to GET array is not a good practice.

2) I assume you are using correct syntax for your FORM submit.

3) IMO, you could remove the SESSION variable as you are explicitly passing as GET parameter in the subsequent urls. Or dont use the GET parameter in urls.