Question

I have a PowerShell 2.0 script that I use to delete folders that have no files in them:

dir 'P:\path\to\wherever' -recurse | Where-Object { $_.PSIsContainer } | Where-Object { $_.GetFiles().Count -eq 0 } | foreach-object { remove-item $_.fullname -recurse}

However, I noticed that there were a ton of errors when running the script. Namely:

Remove-Item : Directory P:\path\to\wherever cannot be removed because it is not empty.

"WHAT?!" I panicked. They should all be empty! I filter for only empty folders! Apparently that’s not quite how the script is working. In this scenario a folder that has only folders as children, but files as grandchildren is considered empty of files:

Folder1 (no files - 1 folder) \ Folder 2 (one file)

In that case, PowerShell sees Folder1 as being empty and tries to delete it. The reason this puzzles me is because if I right-click on Folder1 in Windows Explorer It says that Folder1 has 1 folder and 1 file within it. Whatever is used to calculate the child objects underneath Folder1 from within Explorer allows it to see grandchild objects ad infinitum.

Question:

How can I make my script not consider a folder empty if it has files as grandchildren or beyond?

Answer 1

There were some issues in making this script, one of them being using this to check if a folder is empty:

{!$_.PSIsContainer}).Length -eq 0

However, I discovered that empty folders are not sized with 0 but rather NULL. The following is the PowerShell script that I will be using. It is not my own. Rather, it is from PowerShell MVP Richard Siddaway. You can see the thread that this function comes from over at this thread on PowerShell.com.

function remove-emptyfolder {
 param ($folder)

 foreach ($subfolder in $folder.SubFolders){

 $notempty = $false
 if (($subfolder.Files | Measure-Object).Count -gt 0){$notempty = $true}
 if (($subFolders.SubFolders  | Measure-Object).Count -gt 0){$notempty = $true}
 if ($subfolder.Size -eq 0 -and !$notempty){
   Remove-Item -Path $($subfolder.Path) -Force -WhatIf
 }
 else {
  remove-emptyfolder $subfolder
 }

}

}

$path = "c:\test"
$fso = New-Object -ComObject "Scripting.FileSystemObject"

$folder = $fso.GetFolder($path)
remove-emptyfolder $folder