Question

I have a problem where I am getting an id from a selected checkbox, then it sends it to a delete method and it then passes the id to a stored procedure. The problem I am having though is it is returning my id in a wrong format (“232,4323”) instead of (“232″,”4323”) so when it comes to passing in values to the stored procedure, it craps out because of the string format.
Here is my code in the aspx.

function doTheDelete(doIDeleteTimeTracker) {
    var selectedTimeTrackerList = getSelectedTimeTrackerIDs();
    if (selectedTimeTrackerList.length > 0) {
        $.ajax({
            type: "POST",
            //url: "/Tasks/ViewTasks.aspx/deleteTasksAndLinkedItems",
            url: '<%=ResolveUrl("~/TimeTrackers/ViewTimeTrackers.aspx/deleteSelectedTimeTracker")%>',
            data: "{'DeleteTimeTracker' : '" + doIDeleteTimeTracker + "'," + "'TimeBill': ['" + selectedTimeTrackerList.join(',') + "']}",
            //dataaaaaa
            contentType: "application/json; charset=utf-8",
            dataType: "json",
            success: function (data) {
                var ss = data.d;
                if (ss.length > 0) {
                    for (var i = 0; i < ss.length; ++i) {
                        $.noty.consumeAlert({ layout: 'center', type: 'error', dismissQueue: true });
                        alert(ss[i]);
                    }
                }
                $("#viewTimeTrackersGrid").flexReload();
                showMessage('Successfully Removed Time Tracker');
            },
            error: function (data) {
                $.noty.consumeAlert({ layout: 'center', type: 'error', dismissQueue: true, modal: true });
                alert('Error Deleting Time Tracker');
                if (window.console) {
                    console.log(data);
                }
            }
        });
    } else {
        showMessage('No time tracker(s) are selected.');
    }
}

and here is my delete method in the code behind.

public static string[] deleteSelectedExpense(bool DeleteExpenses, String[] ExpId)
{
    var rList = new List<string>();
    //var canDeleteTasks = false;
    //var canDeleteTrackers = false;
    var canDeleteExpenses = false;
    var investigatorID = (int)HttpContext.Current.Session["InvestigatorID"];
    var conn = new SqlConnection(ConfigurationManager.ConnectionStrings["connect"].ToString());
    var cmd = new SqlCommand("p_Admin_Permissions_CanDeleteExpenses", conn);
    cmd.Parameters.Add(new SqlParameter("@InvestigatorID", SqlDbType.Int));
    cmd.Parameters["@InvestigatorID"].Value = investigatorID;
    cmd.CommandType = CommandType.StoredProcedure;
    try
    {
        conn.Open();
        canDeleteExpenses = (bool)cmd.ExecuteScalar();
    }
    catch (SqlException sql)
    {
        if (!rList.Contains("Can not connect to the database. Please try again."))
            rList.Add("Can not connect to the database. Please try again.");
    }
    catch (Exception ex)
    {
        if (!rList.Contains("An Error Occured"))
            rList.Add("An Error Occured");
    }
    finally
    {
        if (conn.State == ConnectionState.Open)
            conn.Close();
    }

    if (canDeleteExpenses)
    {
        foreach (var expense in ExpId)// expense ends up beng ("232,423") instead of just taking 1 string at a time ("232").....("423")...
        {

            if (canDeleteExpenses)
            {
                conn = new SqlConnection(ConfigurationManager.ConnectionStrings["OSCIDConnectionString"].ToString());
                cmd = new SqlCommand("p_CaseFiles_Expenses_DeleteExpenses", conn);
                cmd.Parameters.Add(new SqlParameter("@ExpID", SqlDbType.Int));
                cmd.Parameters["@ExpID"].Value = int.Parse(expense);
                cmd.Parameters.Add("@Message", SqlDbType.NVarChar, 50);
                cmd.Parameters["@Message"].Direction = ParameterDirection.Output;
                cmd.CommandType = CommandType.StoredProcedure;
                try
                {
                    conn.Open();
                    cmd.ExecuteNonQuery();
                }
                catch (SqlException sql)
                {
                    if (!rList.Contains("Error Connecting to the Database. Unable To Delete Expense(s)."))
                        rList.Add("Error Connecting to the Database. Unable To Delete Expense(s).");
                }
                catch (Exception ex)
                {
                    if (!rList.Contains("An Error Occured"))
                        rList.Add("An Error Occured");
                }
                finally
                {
                    if (conn.State == ConnectionState.Open)
                        conn.Close();
                }
            }
            else if (!canDeleteExpenses)
            {
                rList.Add("You do not have permission to delete Expenses");
            }
            else
            {
                if (!rList.Contains("You do not have permission to delete the Expense(s)."))
                    rList.Add("You do not have permission to delete the Expense(s).");
            }
        }
    }
    return rList.ToArray();
}

I am guessing it could be in the “Data :” in the ajax call formatting for the array(I’ve tried a few things)

Answer 1

thanks for the help gents. I managed to fix it. Solution was to do this:

 "'ExpId': ['" + selectedExpensesList.join('\',\'') + "']}",

instead of :

 "'ExpId': ['" + selectedExpensesList.join(',') + "']}",

adding the extra ‘ seemed to work. It then manages to take each id seperately instead of taking the entire array and pooping on me