Question

I have a problem with this query:

SELECT     RTRIM(LTRIM(L_MAILITMS.MAILITM_FID)) AS Ref30
         , IsNull (Ref33,0) as Ref33
FROM       L_MAILITM_EVENTS 
   INNER JOIN L_MAILITMS ON L_MAILITM_EVENTS.MAILITM_PID = L_MAILITMS.MAILITM_PID 
WHERE  (L_MAILITMS.MAIL_CLASS_CD = 'E') 
   AND (L_MAILITM_EVENTS.EVENT_OFFICE_CD = 1063) 
   AND (L_MAILITM_EVENTS.EVENT_TYPE_CD = 30) 
   AND (L_MAILITM_EVENTS.EVENT_GMT_DT >= CONVERT(DATETIME, '2012-05-27 00:00:00', 102)) 
   AND (L_MAILITM_EVENTS.EVENT_GMT_DT < CONVERT(DATETIME, '2012-05-28 00:00:00', 102))
LEFT OUTER JOIN 
  (
    SELECT   RTRIM(LTRIM(L_MAILITMS_1.MAILITM_FID)) as Ref3033
           , COUNT(*) as Ref33
    FROM     L_MAILITM_EVENTS as L_MAILITM_EVENTS_1 
       INNER JOIN  L_MAILITMS as L_MAILITMS_1 ON L_MAILITM_EVENTS_1.MAILITM_PID = L_MAILITMS_1.MAILITM_PID
    WHERE  (L_MAILITMS_1.MAIL_CLASS_CD = 'E') 
       AND (L_MAILITM_EVENTS_1.EVENT_OFFICE_CD = 1063) 
       AND (L_MAILITM_EVENTS_1.EVENT_TYPE_CD = 33) 
       AND (L_MAILITM_EVENTS_1.EVENT_GMT_DT >= CONVERT(DATETIME, '2012-05-27 00:00:00', 102))
    GROUP BY L_MAILITMS_1.MAILITM_FID
  )  ON L_MAILITMS.MAILITM_FID = L_MAILITMS_1.MAILITM_FID

an error is generated

Msg 156, Level 15, State 1, Line 7
Incorrect syntax near the keyword ‘LEFT’.
Msg 156, Level 15, State 1, Line 16
Incorrect syntax near the keyword ‘ON’.

Table L_MAILITMS_EVENTS:

MAILITM_PID     EVENT_OFFICE_CD    EVENT_TYPE_CD
-----------------------------------------------------------
1               1063               30
2               1063               30
2               1063               33
3               1063               33
3               1063               30
4               1063               30

Table L_MAILITMS:

MAILITM_PID          MAILITM_FID        MAIL_CLASS_CD
-------------------------------------------------------
1                     123               E  
2                     452               E                
3                     369               E
4                     633               E

What i want to get:

Ref30          Ref33
-----------------------
123            0
452            1
369            1
633            0

UPDATE : Thanks Sebas for your help

*is there another way for this query to assure speed performance, because i treat about 2500 MAILITM_FID ?*

Can anyone help?
thanks

Answer 1

Then let me modify the placement of the joins:

    SELECT     RTRIM(LTRIM(m.MAILITM_FID)) AS Ref30
         , IsNull (Ref33,0) as Ref33
FROM       L_MAILITM_EVENTS me
   INNER JOIN L_MAILITMS m ON me.MAILITM_PID = m.MAILITM_PID
   LEFT OUTER JOIN (
            SELECT   RTRIM(LTRIM(m1.MAILITM_FID)) as Ref3033
                   , COUNT(*) as Ref33
            FROM     L_MAILITM_EVENTS me1
                        INNER JOIN L_MAILITMS m1 ON me1.MAILITM_PID = m1.MAILITM_PID
            WHERE  (m1.MAIL_CLASS_CD = 'E') 
               AND (me1.EVENT_OFFICE_CD = 1063) 
               AND (me1.EVENT_TYPE_CD = 33) 
               AND (me1.EVENT_GMT_DT >= CONVERT(DATETIME, '2012-05-27 00:00:00', 102))
            GROUP BY m1.MAILITM_FID
  ) oj ON m.MAILITM_FID = oj.Ref3033 
WHERE  (m.MAIL_CLASS_CD = 'E') 
   AND (me.EVENT_OFFICE_CD = 1063) 
   AND (me.EVENT_TYPE_CD = 30) 
   AND (me.EVENT_GMT_DT >= CONVERT(DATETIME, '2012-05-27 00:00:00', 102)) 
   AND (me.EVENT_GMT_DT < CONVERT(DATETIME, '2012-05-28 00:00:00', 102))

I didn’t check the logic of your joins, I just moved them. Try and see if there’s still this syntax error..