Home/ Questions/Q 7755563
In Process

The Archive Base Latest Questions

Editorial Team
  • 0
Asked: 2026-06-01T12:36:02+00:00

I have a problem with this script. At first I had the <div> s

  • 0

I have a problem with this script. At first I had the <div>s hard-coded and it was working fine. But then I needed to alter the navigation bar dynamically because I changed the (number of) links.

The problem is that the id’s are not registering when they are injected with element.innerHTML = (html string).

How can I fix this?

Here is the code:

javascript:

 function constructNav() {
   var submenu_layer_innerHTML = "";
   var top_nav_innerHTML = "<UL class=\"nav_category\">";
   for (i=0; i<links.length; i++) {
     submenu_layer_innerHTML = "<div class=\"submenu\" id=\"submenu" + i + "\" onMouseOut=\"timeHideNav('" + i + "','1000')\"> </div>";
     top_nav_innerHTML += "<LI id=\"link" + i + "\"><a href=# onMouseOver=\"expandNav('" + i + "');\">" + links[i] + "</a></LI>";
   }
   top_nav_innerHTML += "</UL>";
   document.getElementById("top_nav").innerHTML = top_nav_innerHTML;
   document.getElementById("submenu_layer").innerHTML = submenu_layer_innerHTML;
 }

html:

<script type="text/javascript" src="scripts.js"> </script>
<script type="text/javascript">
var links =["link 1",
    "link 2",
    "link 3",
    "link 4",
    "link 5",
    "link 6"];
</script>

<body onLoad="constructNav();">

<div id="submenu_layer"> </div>
<div id="top_nav"> </div>

I’m getting this error in firefox:

  line 35: document.getElementById("submenu"+pageNo) is NULL
Share

Leave an answer

You must login to add an answer.

Need An Account,

1 Answer

  1. Editorial Team

    You are overwriting submenu_layer_innerHTML during each iteration of the for loop. Make sure to use +=.

    • 0