Question

I have a question about this procedure. What I am trying to do is to pass in one variable which is the ID, then set a veraible out and return a query / cursor. I got some help on this yesterday, but something is not right and it won’t compile. Can someone help me sort this out? Here is what I have so far.

PROCEDURE SEEKER (pMonkeyID IN VARCHAR2, vMarkCounter OUT Number, seeker_cur OUT TYPES.ref_cursor)
AS
BEGIN

CURSOR seeker_cur IS
    Select monkey_doc_approved, monkey_doc_vaulted
    from monkeyApps 
    where MonkeyID = pMonkeyID
    and monkey_doc_type = 'Banana' 
    order by monkey_doc_approved_timestamp,monkey_doc_type,monkey_doc_approved desc

vMarkCounter number:=0;
BEGIN
  FOR i IN seeker_cur 
  LOOP
    vMarkCounter := vMarkCounter+1;
  END LOOP;
END;

END SEEKER;

I am not sure I am setting my cursor for returning right, and I am not sure I am looping correctly to set my monkeyMarker. the cursor needs to return as well as the marker because I deal with some front end logic with both.

Thanks,
Frank

Answer 1

I’ll agree with AB Cade I don’t understand why you need the records and the count.There should, however, be little to no need to loop though a cursor in PL\SQL; you can use bulk collect instead, which returns what you want.

If you don’t have that many records, say less than 50k I would remove the limit 10000 part of the bulk collect; you can just use t_seeker.count, which’ll give you your answer.

PROCEDURE SEEKER ( pMonkeyID IN VARCHAR2
                 , vMarkCounter OUT Number
                 , c_seeker OUT TYPES.ref_cursor) IS

  cursor c_seeker is
    select monkey_doc_approved, monkey_doc_vaulted
      from monkeyApps 
     where MonkeyID = pMonkeyID
       and monkey_doc_type = 'Banana' 
     order by monkey_doc_approved_timestamp
            , monkey_doc_type
            , monkey_doc_approved desc
           ;

  type t__seeker is table of c_seeker%rowtype index by binary_integer;
  t_seeker t__seeker;

  vMarkCounter number := 0;

begin

  open c_seeker;
  loop

     fetch c_seeker bulk collect into t_seeker limit 10000;

     vMarkCounter := vMarkCounter + t_seeker.count;

  end loop;

  -- OP want's to return a ref_cursor.
  --close c_seeker;

end seeker;
/