Question

I have a question that is puzzling me recently about which is the best way to retrieve attributes from outside.

Let say I have a class:

class Thing:
    def __init__(self, whatever):
        self.whatever = whatever

x = Thing('foo')

Now I know that if I want to retrieve whatever attribute I can do this:

x.whatever

I have the habit (probably because I come from other oo languages) to define methods to retrieve class attributes as needed and use them insted of retrieve them directly, like:

class Thing:
    def __init__(self, whatever):
        self.whatever = whatever

    def getWhatever(self):
        return self.whatever

In my little experience I’ve found that using this approach make things easier to mantain in the long term because if I edit the structure of data attributes I have to edit only the specific method.

But since I am not really a python veteran I’d love to know if I am doin’ it right or if some other approaches are better and more pythonic. Thoughts?

Answer 1

Defining explicit getters and setters is a bad practice in Python. Instead, use properties:

class Thing(object): # New-style class
    def __init__(self, whatever):
        self._whatever = whatever

    @property
    def whatever(self):
        return self._whatever # Insert complicated calculation here

So instead of pre-planning by using get methods, just introduce a property when you actually need advanced behavior, and not any earlier.