Question

I have a scenario. (Windows Forms, C#, .NET)

1. There is a main form which hosts some user control.
2. The user control does some heavy data operation, such that if I directly call the UserControl_Load method the UI become nonresponsive for the duration for load method execution.
3. To overcome this I load data on different thread (trying to change existing code as little as I can)
4. I used a background worker thread which will be loading the data and when done will notify the application that it has done its work.
5. Now came a real problem. All the UI (main form and its child usercontrols) was created on the primary main thread. In the LOAD method of the usercontrol I’m fetching data based on the values of some control (like textbox) on userControl.

The pseudocode would look like this:

CODE 1

UserContrl1_LoadDataMethod() {     if (textbox1.text == "MyName") // This gives exception     {         //Load data corresponding to "MyName".         //Populate a globale variable List<string> which will be binded to grid at some later stage.     } } 

The Exception it gave was

Cross-thread operation not valid: Control accessed from a thread other than the thread it was created on.

To know more about this I did some googling and a suggestion came up like using the following code

CODE 2

UserContrl1_LoadDataMethod() {     if (InvokeRequired) // Line #1     {         this.Invoke(new MethodInvoker(UserContrl1_LoadDataMethod));         return;     }      if (textbox1.text == "MyName") // Now it won't give an exception     {     //Load data correspondin to "MyName"         //Populate a globale variable List<string> which will be binded to grid at some later stage     } } 

But it still seems that I’ve come back to square one. The Application again becomes unresponsive. It seems to be due to the execution of line #1 if condition. The loading task is again done by the parent thread and not the third that I spawned.

I don’t know whether I perceived this right or wrong.

How do I resolve this and also what is the effect of execution of Line#1 if block?

The situation is this: I want to load data into a global variable based on the value of a control. I don’t want to change the value of a control from the child thread. I’m not going to do it ever from a child thread.

So only accessing the value so that the corresponding data can be fetched from the database.

Answer 1

As per Prerak K’s update comment (since deleted):

I guess I have not presented the question properly.

Situation is this: I want to load data into a global variable based on the value of a control. I don’t want to change the value of a control from the child thread. I’m not going to do it ever from a child thread.

So only accessing the value so that corresponding data can be fetched from the database.

The solution you want then should look like:

UserContrl1_LOadDataMethod() {     string name = "";     if(textbox1.InvokeRequired)     {         textbox1.Invoke(new MethodInvoker(delegate { name = textbox1.text; }));     }     if(name == "MyName")     {         // do whatever     } } 

Do your serious processing in the separate thread before you attempt to switch back to the control’s thread. For example:

UserContrl1_LOadDataMethod() {     if(textbox1.text=="MyName") //<<======Now it wont give exception**     {         //Load data correspondin to "MyName"         //Populate a globale variable List<string> which will be         //bound to grid at some later stage         if(InvokeRequired)         {             // after we've done all the processing,              this.Invoke(new MethodInvoker(delegate {                 // load the control with the appropriate data             }));             return;         }     } }