Question

I have a script I’m using to rotate images in an un-ordered list (LI). The script works fine if there is one single instance of the referenced class on the page. However, if I have 2 instances of the rotating component, the second instance does not respond.

I think the solution is making the script continue to run until the second rotator gets it, but I’m not sure. I’ve tried a couple modifications with no luck. The current script is below:

function theRotator() {
    //Set the opacity of all images to 0
    $('div.rotator ul li').css({opacity: 0.0});

    // Remove images that only show in main-content
    $('div.rotator ul li.page-only').remove();

    //Get the first image and display it (gets set to full opacity)
    $('div.rotator ul li:first').css({opacity: 1.0});

    //Call the rotator function to run the slideshow, 6000 = change to next image after 6 seconds
    setInterval('rotate()',4000);
}

function rotate() { 
    //Get the first image
    var current = ($('div.rotator ul li.show')?  $('div.rotator ul li.show') : $('div.rotator ul li:first'));

    if ( current.length == 0 ) current = $('div.rotator ul li:first');

    //Get next image, when it reaches the end, rotate it back to the first image
    var next = ((current.next().length) ? ((current.next().hasClass('show')) ? $('div.rotator ul li:first') :current.next()) : $('div.rotator ul li:first'));

    //Un-comment the 3 lines below to get the images in random order

    //var sibs = current.siblings();
    //var rndNum = Math.floor(Math.random() * sibs.length );
    //var next = $( sibs[ rndNum ] );


    //Set the fade in effect for the next image, the show class has higher z-index
    next.css({opacity: 0.0})
    .addClass('show')
    .animate({opacity: 1.0}, 500);

    //Hide the current image
    current.animate({opacity: 0.0}, 1000)
    .removeClass('show');

};
setTimeout(function(){
    $(document).ready(function() {      
        //Load the slideshow
        theRotator();
        $('div.rotator').fadeIn(500);
        $('div.rotator ul li').fadeIn(500); // tweek for IE
    });
}, 500);

Answer 1

You probably need to replace :first in your selectors with :first-child. :first acts like .first() and selects only one element, while :first-child behaves like its CSS equivalent.