Question

I have a SelectSP which returns resultset that i am storing in the temp table. Now i want to call another SP named InsertSP and pass the values from this temp table as parameter to the it.

Here is the code i have so far:

CREATE TABLE #tempTable
(
    Field1 VARCHAR(255),
    Field2 VARCHAR(255),
    Field3 VARCHAR(255),
    Field4 VARCHAR(255),
    Field5 VARCHAR(255),
    Field6 VARCHAR(255),
    Field7 VARCHAR(255)
        .
        .
        .

)

INSERT INTO #tempTable exec 
usp_SelectSP 'p1' ,'p2', 'p3'

Now i want to execute one more SP and pass Field1, Field2, Field3 of tempTable as parameter to that SP.

I was thinking something like this

usp_InsertSP
  @param1 = Field1
  @Param2 = Field2
  @Param3 = Field3

FROM #tempTable.

What is the best way to do this?

Answer 1

If you can’t change the called SP then easiest way would probably be a cursor:

DECLARE @f1 VARCHAR(255), @f2 VARCHAR(255) --, ...

DECLARE c CURSOR 
  LOCAL STATIC READ_ONLY FORWARD_ONLY
  FOR SELECT Field1, Field2 --, ...
    FROM #tempTable;

OPEN c;

FETCH NEXT FROM c INTO @f1, @f2 --, ...

WHILE @@FETCH_STATUS <> -1
BEGIN
  EXEC usp_InsertSP
    @param1 = @f1,
    @param2 = @f2 --, ...

  FETCH NEXT FROM c INTO @f1, @f2 --, ...
END

CLOSE c;
DEALLOCATE c;

However I strongly recommend you change the called procedure. There is almost absolutely a more efficient way to deal with the data in this #temp table if you can change the called procedure to use it directly.

EDIT

Demonstrating that a called proc can see a #temp table created by the caller.

CREATE PROCEDURE dbo.proc1
AS
BEGIN
    SET NOCOUNT ON;

    CREATE TABLE #t1(a INT);

    INSERT #t1 SELECT 1 UNION SELECT 2;

    EXEC dbo.proc2;

    DROP TABLE #t1;
END
GO

CREATE PROCEDURE dbo.proc2
AS
BEGIN
    SET NOCOUNT ON;

    SELECT a FROM #t1;
END
GO

EXEC dbo.proc1;

Results:

a
-
1
2