Question

I have a @SessionScoped ApplicationBean for storing user login info and injecting it into other managed beans successfully as told here.

I also use my Dao interfaces by @ManagedProperty annotation but I feel something wrong with my usage.

Assume that there is as StockDao that has a public method listStocks(String companyCode) and companyCode is stored in the ApplicationBean when user logins.

So my managed bean is calling the DAO layer like this

@ManagedProperty(value = "#{appBean}")
ApplicationBean appBean;

public void getStockList() {    
    return stockDao.listStocks(appBean.getCompanyCode());       
}

This repeats everywhere where the sql needs companyCode.

I feel that it would be better if my DAO layer had known companyCode (which means injecting ApplicationBean into DAOs) and I should use my methods like below

public void getStockList() {    
    return stockDao.listStocks();       
}

So the question is, which API design would be better and if you vote for the second, how can I inject @SessionScoped beans into DAO layer?

Answer 1

For me 1st approach is much cleaner ,
i dont want to tie DAO layer with the session managed bean.

I keep my general artifacts especially daos and data models packaged as a seperate Jar , without any external dependencies
This way i could use the same without any modifications be it a Web App , Stand Alone or in an EJB

This keeps your Dao independent of how/where the Company Code is fetched from