Question

I have a simple question. I am designing some simple highscores code yet I am having alot of trouble with it, specifically storing and saving players names. I have not been programming for very long in obj-c, only 2 weeks. I am not quite sure what is going on when I use NSStrings in an array.

Here is the code for saving strings:

-(NSString *) getFilePath2 {
    NSArray *pathArray = NSSearchPathForDirectoriesInDomains(NSDocumentDirectory, NSUserDomainMask, YES);
    return [[pathArray objectAtIndex:0] stringByAppendingPathComponent:@"savedFile2.plist"];


}

-(void) savePlayerNameData {
    NSArray *highScoreNames = [[NSArray alloc]
                                initWithObjects:

                                playerName1,

                                playerName2,

                                playerName3,

                                playerName4,

                                playerName5,

                                nil];


    [highScoreNames writeToFile:[self getFilePath2] atomically:YES];

}

-(void) loadPlayerNameData{
    // load data here
    NSString *myPath = [self getFilePath2];
    BOOL fileExists = [[NSFileManager defaultManager] fileExistsAtPath:myPath];

    if (fileExists) {
        NSArray *values = [[NSArray alloc] initWithContentsOfFile:myPath];
        playerName1 = [values objectAtIndex:0];
        playerName2 = [values objectAtIndex:1];
        playerName3 = [values objectAtIndex:2];
        playerName4 = [values objectAtIndex:3];
        playerName5 = [values objectAtIndex:4];




    }
    else {
        NSLog(@"first Launch. no file yet");
    }
}

I end up getting this error :

2012-08-15 22:25:30.780 Pig Fly![5304:f803] *** Terminating app due to uncaught exception 'NSRangeException', reason: '-[__NSCFArray objectAtIndex:]: index (0) beyond bounds (0)'
*** First throw call stack:
(0x14c5022 0xec5cd6 0x146da48 0x146d9b9 0x14bec30 0xbd21 0x62e2 0x964eb6 0x1499936 0x14993d7 0x13fc790 0x13fbd84 0x13fbc9b 0x13ae7d8 0x13ae88a 0x28626 0x1fdd 0x1f45)
terminate called throwing an exception(lldb) 

However, what I find very interesting is that when I write similar code for saving int values, The program runs fine. This is the working int code:

-(NSString *) getFilePath {
    NSArray *pathArray = NSSearchPathForDirectoriesInDomains(NSDocumentDirectory, NSUserDomainMask, YES);
    return [[pathArray objectAtIndex:0] stringByAppendingPathComponent:@"savedFile.plist"];
}


-(void) saveData {
    //save data here
    NSArray *highScores = [[NSArray alloc]
                           initWithObjects:

                           [NSString stringWithFormat:@"%i",highScore1],

                           [NSString stringWithFormat:@"%i",highScore2],

                           [NSString stringWithFormat:@"%i",highScore3],

                           [NSString stringWithFormat:@"%i",highScore4],

                           [NSString stringWithFormat:@"%i",highScore5],

                            nil];


    [highScores writeToFile:[self getFilePath] atomically:YES];



}

-(void) loadData{
    // load data here
    NSString *myPath = [self getFilePath];
    BOOL fileExists = [[NSFileManager defaultManager] fileExistsAtPath:myPath];

    if (fileExists) {
        NSArray *values = [[NSArray alloc] initWithContentsOfFile:myPath];
        highScore1 = [[values objectAtIndex:0] intValue];
        highScore2 = [[values objectAtIndex:1] intValue];
        highScore3 = [[values objectAtIndex:2] intValue];
        highScore4 = [[values objectAtIndex:3] intValue];
        highScore5 = [[values objectAtIndex:4] intValue];




    }
    else {
        NSLog(@"first Launch. no file yet");
    }
}

Can anybody tell me what is going on? What are the differences that need to be kept in mind when writing NSArrays for ints and NSStrings?

Answer 1

Make sure that playerName1 is not NULL.