Question

I have a single spring bean similar to the following:

public class MyServiceImpl {
    private MyDAO myDAO;

    public class MyInnerClass implements SomeInterface<MyInnerClass> {

        @Override
        public MyInnerClass loadFreshObject(final String key) {
            return myDAO.load(key);
        }
    }

}

Instances of MyInnerClass are being created in code outside of the spring bean but no reference to those instances are being kept.

Assuming I have no control over the use of these public non-static inner classes (I know ideally these would be private and static to avoid leaking the reference to ‘this’), will the created instances of ‘MyInnerClass’ be correctly garbage collected?

I have run my own tests on this by overriding the finalize() and it appears that the instances are correctly being garbage collected, I was just hoping for clarification on this.

Thanks

Answer 1

Instances of the inner class will be garbage collected according to normal rules (i.e. when they are no longer referenced). However, each instance of the inner class contains a hidden reference to its parent instance of the outer class. This means that if there are any live references to instances of the inner class, they will prevent the associated instances of the outer class from being garbage collected. But it only works in that direction, not the other way around.