Question

I have a small script that defines a variable called $prPrice. This script is not working in the way that I intend, as in some of the products that contain a certain department code are display prices relating to other department codes. So i assume that the way i have initially put this together is somehow wrong.

My question would be this, can anyone spot a problem with, or provide suggestions for bettering the following simple php script:

// Cost plus 2.5%
if ($prDept = (204 || 205 || 209 || 1501 || 1601 )) {
    if ($_SESSION['tax'] == "on" || !isset($_SESSION['tax']))
        $prPrice = ((($prCost1 / 1.14) * 1.025) * 1.14);
    else if ($_SESSION['tax'] == "off" && $prTaxable == "1")
        $prPrice = ($prCost1 * 1.025);
    else if ($_SESSION['tax'] == "off" && $prTaxable == "0")
        $prPrice = (($prCost1 / 1.14) * 1.025);

}

Answer 1

$prDept = (204 || 205 || 209 || 1501 || 1601)

That is not how this works in PHP. It really needs to look like…

$prDept == 204 || $prDept == 205 || $prDept == 209 || $prDept == 1501 || $prDept == 1601

or alternatively,

in_array($prDept, array(204, 205, 209, 1501, 1601))