Home/ Questions/Q 3278378
In Process

The Archive Base Latest Questions

Editorial Team
  • 0
Asked: 2026-05-17T19:28:28+00:00

I have a stored procedure that has a BEGIN TRANSACTION and COMMIT TRANSACTION statement.

  • 0

I have a stored procedure that has a BEGIN TRANSACTION and COMMIT TRANSACTION statement. Within the transaction is a select query WITH(XLOCK, ROWLOCK).

The transaction can potentially fail due to some calculations that cause an arithmetic overflow error if out of bounds values are supplied. This error would happen before any insert/update statements.

My question is, should I wrap the transaction in a TRY/CATCH and rollback or is this not really required and all locks would be released automatically if the transaction fails? My only concern here is that SQL would not release all locks of the transaction in case the transaction fails.

Thanks,

Tom

Share

Leave an answer

You must login to add an answer.

Need An Account,

1 Answer

  1. Editorial Team

    Short answer: Yes.

    Whenever I use BEGIN TRANSACTION, I always include use error handling and ROLLBACK. The consequences of hitting an unanticipated (and/or unanticipatable — you can’t know how your code may need to be modified in the future) situation that leaves an open transaction on a Production server are too severe to not do it.

    In SQL Server 2000 and earlier, you have to use @@Error logic. In SQL 2005 and up, you get to use the (far superior) TRY…CATCH… syntax.

    • 0