Question

I have a subroutine that runs when I click a button on my form. The problem is that no matter what happens, the error block is executed, and I can’t figure out why. I’m not very good with Access VBA, so it may be a simple error.

Here’s my sub:

Public Sub findRecord()

    Dim rs As DAO.Recordset

    Set rs = Me.[dbo_NCL_SimmonsCodes subform1].Form.Recordset

    rs.FindFirst "NCL_ItemNum=""LSIM-" & Me.Text0 & """"

    If rs.NoMatch Then

         MsgBox "No match found.  Please try again." & vbNewLine & vbNewLine & "If this is a new item, please click the Add Record button to add.", vbInformation, "No Match"

    End If

On Error GoTo description_Error

    Me.lblDescription.Caption = DLookup("Description", "dbo_AL_ItemUPCs", "ItemCode ='" & Me.Text0 & "'")

Exit_FindRecord:
    Exit Sub

description_Error:

        MsgBox "Error " & Err.Number & ": " & Err.Description & vbNewLine & vbNewLine, vbExclamation, "VBA Error " & Err.Number
        Me.lblDescription.Caption = "Error."
        Resume Exit_FindRecord

End Sub

Answer 1

Actually looks like a logic error. If the FindFirst statement has no match, it the routine should exit there, instead of continuing. I added ‘Exit Sub’ below that messagebox, and now I’m good.

Public Sub findRecord()

    Dim rs As DAO.Recordset

    Set rs = Me.[dbo_NCL_SimmonsCodes subform1].Form.Recordset

    rs.FindFirst "NCL_ItemNum=""LSIM-" & Me.Text0 & """"

        If rs.NoMatch Then
                MsgBox "No match found.  Please try again." & vbNewLine & vbNewLine & "If this is a new item, please click the Add Record button to add.", vbInformation, "No Match"
                Me.lblDescription.Caption = "Error - No match."
                Exit Sub      
                '^^Added^^'
        End If

On Error GoTo description_Error

            Me.lblDescription.Caption = DLookup("Description", "dbo_AL_ItemUPCs", "ItemCode ='" & Me.Text0 & "'")

Exit_FindRecord:
        Exit Sub

description_Error:
        MsgBox "Error " & Err.Number & ": " & Err.Description & vbNewLine & vbNewLine, vbExclamation, "VBA Error " & Err.Number
        Me.lblDescription.Caption = "Error."
        Resume Exit_FindRecord

End Sub