Question

i have a table empinf
fields

Empid int
EmpName Nvarchar
Salary Numeric

i have a EmployeeUtility class which contains a Method Getdetails

public EmployeeDetails Getdetails(int employeeId)
    {
        SqlConnection con = new SqlConnection(connectionString);
        SqlCommand cmd = new SqlCommand("SelectEmployee", con);
        cmd.CommandType = CommandType.StoredProcedure;
        cmd.Parameters.Add(new SqlParameter("@Id",SqlDbType.Int,4));
        cmd.Parameters["@Id"].Value=employeeId;


            try
               {
        con.Open();

        SqlDataReader reader = cmd.ExecuteReader();
        if (!reader.HasRows) return null;
        reader.Read();
        EmployeeDetails emp = new EmployeeDetails((int)reader["EmpId"], (string)reader["EmpName"], (int)reader["Salary"]);
        reader.Close();
        return emp;
    }
    catch (SqlException e)
    {
        throw new ApplicationException("Data error.");

    }
    finally
    {
        con.Close();
    }


    } 


EmployeeDetails emp=new EmployeeDetails((int)reader["EmpId"],(string)reader["EmpName"],(int)reader["Salary"]);

it shows an error in this line indicating Specified cast is not valid. please need assistance in it.

my employeeDetails class is as follows:

public class EmployeeDetails
{
    private int employeeID;
    public int EmployeeID
    {
        get { return employeeID; }
        set { employeeID = value; }
    }

    private string employeeName;
    public string EmployeeName
    {
        get { return employeeName; }
        set { employeeName = value; }
    }

    private int salary;
    public int Salary
    {
        get { return salary; }
        set { salary = value; }
    }

    public EmployeeDetails(int employeeId, string employeeName, int salary)
    {
        EmployeeID = employeeID;
        EmployeeName = employeeName;
        Salary = salary;
    }

    public EmployeeDetails()
    {
        // TODO: Complete member initialization
    }

}

Answer 1

Try this:

EmployeeDetails emp=new EmployeeDetails(Convert.ToInt32(reader["EmpId"]),Convert.ToString(reader["EmpName"]),Convert.ToInt32(reader["Salary"]));

//this assumes that you don't have NULL values in any of those columns, because if you do, it will fail.  It would be more safe to check for DBNull.Value before trying to Cast these values.