Question

I have a UISearchBar setup and when its being used, it has an overlay grey view that covers the rest of the table similar to how apple does it.

When I click this darkened view, it exits search mode, which is good, but when I search again, then again click the grey to exit, it crashes with EXC BAD ACCESS error.

Here is some related code:

The crash is always at [rvController doneSearching_Clicked:nil];

OverlayViewController.h

@interface OverlayViewController : UIViewController

@property (nonatomic, retain) ChooserViewController *rvController;
@property (nonatomic, retain) CPTViewController *cptViewController;


@implementation OverlayViewController

- (void)touchesBegan:(NSSet *)touches withEvent:(UIEvent *)event {

    [rvController doneSearching_Clicked:nil];
    [cptViewController doneSearching_Clicked:nil];
}

- (void) dealloc {
    [rvController release];
    [cptListViewController release];
    [super dealloc];
}

@end

Code for the actual VC with the search bar

- (void) searchBarSearchButtonClicked:(UISearchBar *)theSearchBar
{
    searching = YES;
    [ovController.view removeFromSuperview];
    letUserSelectRow = YES;
    self.tableView.scrollEnabled = YES;
    if (self.mySearchBar.text !=nil)
    {
        NSPredicate *predicate =[NSPredicate predicateWithFormat:@"(name contains[cd] %@) OR (code contains[cd] %@)", self.mySearchBar.text, self.mySearchBar.text];
        [fetchedResultsController.fetchRequest setPredicate:predicate];
    }
    else
    {
        NSPredicate *predicate =[NSPredicate predicateWithFormat:@"All"];
        [fetchedResultsController.fetchRequest setPredicate:predicate];
    }

    NSError *error = nil;
    if (![[self fetchedResultsController] performFetch:&error]) 
    {
        NSLog(@"Unresolved error %@, %@", error, [error userInfo]);
        exit(-1);  // Fail
    } 

    self.searchArray = fetchedResultsController.fetchedObjects;

    [mySearchBar resignFirstResponder];

    [self.tableView reloadData];
}

- (void) searchBarTextDidBeginEditing:(UISearchBar *)searchBar
{
    self.navigationItem.leftBarButtonItem = nil;

    if(searching)
        return;

    if(ovController == nil)
        ovController = [[OverlayViewController alloc] initWithNibName:@"OverlayView" bundle:[NSBundle mainBundle]];

    CGFloat yaxis = self.navigationController.navigationBar.frame.size.height;
    CGFloat width = self.view.frame.size.width;
    CGFloat height = self.view.frame.size.height;

    CGRect frame = CGRectMake(0, yaxis, width, height);
    ovController.view.frame = frame;    
    ovController.view.backgroundColor = [UIColor grayColor];
    ovController.view.alpha = 0.5;

    ovController.rvContrller = self;

    [self.tableView insertSubview:ovController.view aboveSubview:self.parentViewController.view];

    searching = YES;
    letUserSelectRow = NO;
    self.tableView.scrollEnabled = NO;

    self.navigationItem.rightBarButtonItem = [[[UIBarButtonItem alloc] 
                                               initWithBarButtonSystemItem:UIBarButtonSystemItemCancel 
                                               target:self action:@selector(doneSearching_Clicked:)] autorelease];
}

- (void) searchBarTextDidEndEditing:(UISearchBar *)searchBar
{
    searchBar.showsCancelButton = NO;
}

- (void)searchBar:(UISearchBar *)theSearchBar textDidChange:(NSString *)searchText 
{
    [self.tableView insertSubview:ovController.view aboveSubview:self.parentViewController.view];

    searching = NO;
    letUserSelectRow = NO;
    self.tableView.scrollEnabled = NO;

    [self.tableView reloadData];
}
- (void) doneSearching_Clicked:(id)sender {

    mySearchBar.text = @"";
    [mySearchBar resignFirstResponder];

    letUserSelectRow = YES;
    searching = NO;
    self.navigationItem.rightBarButtonItem = nil;
    self.tableView.scrollEnabled = YES;

    [ovController.view removeFromSuperview];
    [ovController release];
    ovController = nil;

    [self.tableView reloadData];
    [self.tableView scrollToRowAtIndexPath:0 atScrollPosition:UITableViewScrollPositionTop animated:YES];
}

Answer 1

/// @OverlayView
- (void)touchesBegan:(NSSet *)touches withEvent:(UIEvent *)event {

    [rvController doneSearching_Clicked:nil]; ///< Point 1
    [cptViewController doneSearching_Clicked:nil];
}

/// @VC Search bar
- (void) doneSearching_Clicked:(id)sender {

    mySearchBar.text = @"";
    [mySearchBar resignFirstResponder];

    letUserSelectRow = YES;
    searching = NO;
    self.navigationItem.rightBarButtonItem = nil;
    self.tableView.scrollEnabled = YES;

    /// Point 2 
    [ovController.view removeFromSuperview];
    [ovController release];
    ovController = nil;

    [self.tableView reloadData];
    [self.tableView scrollToRowAtIndexPath:0 atScrollPosition:UITableViewScrollPositionTop animated:YES];
}

At the Point 1, it will call -(void)doneSearching_Clicked, then it will execute Point 2. At Point 2, I think the OverlayView object’s retainCount will be 0, that means it will deallocated. So, all pointers the OverlayView has may be invalid, because it releases those objects in -(void)dealloc. According to your codes, that is all I can know.

Edit:
The above procedures may be translated as following format. The -doneSearching_Click will result in [self release] behavior.

/// @OverlayView
- (void)touchesBegan:(NSSet *)touches withEvent:(UIEvent *)event {

    [rvController doneSearching_Clicked:nil]; ///< Point 1
    /// [self release];  /// the above method will do such thing.
    [cptViewController doneSearching_Clicked:nil];
}