Question

I have a vector with raw pointers (no, I cannot use smart pointers) and I want to add items to the list in a for loop. I’ve made a little trial project, and I wondered if this is considered good C++ code in terms of pointer management.

Please only consider raw pointer management, I am not interested in smart pointers for this particular problem I’m trying to solve.

A simple object:

class Request
{
public:
    std::string name;

};

std::vector<Request*> requests;

for (int i = 0; i < 5; i++)
{
    std::stringstream ss;
    ss << "elemenent ";
    ss << i;

    std::string s = ss.str();

    Request* req = new Request();   
    req->name = s;

    requests.push_back(req);

}

EDIT:

So the problem I am trying to solve is adding the DOMNode* to a vector from this library.
I’m starting to get the feeling that trying to write a wrapper for the parts I need from this library for my project, is a bad idea. Or maybe the library is no good?
I haven’t got it to work properly using smart_ptr, if anybody out there has, then I’d like to hear about it.

Answer 1

Well, this leaks memory, so it is bad. Can you use a Pointer Container?

The reason this code leaks is because you create objects on the heap using new, but you never call delete on them.

As for you comment, if you have an object that manually manages some resource, you need The Big Three.