Question

I have a very repetitive conditional sentence. I was wondering if can be cleaned up with a bit of metaprogramming.

This is a simplified example of what I’m dealing with:

FILTERS = [
  :filter1,
  :filter2,
  :filter3
]

def filter1; true; end
def filter2; true; end
def filter3; true; end

if(
  send( FILTERS[0] ) &&
  send( FILTERS[1] ) &&
  send( FILTERS[2] )
)
  puts "DONE!"
end

(In my real case the FILTERS array contains 27 elements)

The target is to replace the three lines into the if sentence with some kind of automatic iteration through all the filter methods.

Another important match is to keep the fast out behavior of the && command: in case filter1 is false neither filter2 or filter3 will be executed.

The FILTERS array is just there to help in finding the elegant solution, you don’t must to use it.

Answer 1

FILTERS.all? {|filter| send(filter) } and puts "DONE!"