Question

I have a view controller that was presented using

[self presentModalViewController:myVC animated:YES];

this VC has several declared retained properties (@property) that I have to release on its dealloc.

The variables are declared as

@property (nonatomic,retain) myClass1 *myProperty;
@property (nonatomic,retain) myClass2 *myProperty2;
// etc... and then synthesized on .m

The problem is that when I dismiss the viewController using

[self dismissModalViewControllerAnimated:YES];  

it crashes on the dealloc, when releasing the retained properties I have declared, with the error *modifying layer that is being finalized *

Apparently the the viewController is gone at the time its own dealloc runs and then it crashes.

How do I solve that? Thanks in advance.

edit

the code that presents the viewController is on the rootViewController and is this:

UIViewController *myVC = [[UIViewController alloc] init];
myVC.delegate = self;

UINavigationController *navigator = [[UINavigationController alloc] initWithRootViewController:myVC];

[self presentModalViewController:navigator animated:YES];
[navigator release];
[myVC release];

and this is the what the dealloc code on myVC contains

- (void) dealloc {
  [myProperty1 release]; // see this properties at the beginning of this question
  [myProperty1 release]; // if I comment these 2 relesases it stops crashing
  [super dealloc];
}

myVC is dismissed from inside itself, but that’s fine according to the docs. I have also tried to dismiss it from the rootviewController but it continues to crash. The only way to stop crashing is to disable the release lines on the dealloc.

Answer 1

How do you set the properties?

self.myProperty = 

? My guess is that you do not retain them. Are you doing

myProperty = ...

by any chance, with neither a retain or self.? The setter you synthesize needs a chance to actually retain your newly created object…

So in full it should read something like this:

MyClass1 *aProperty = [[MyClass1 alloc] init];
self.myProperty1 = aProperty;
[aProperty release];