Question

I have about 9 of these just with different values for were “sourceVal” and “Source” is. I would like to make a method and just pass those two values for each one so my code is cleaner. Is there an easy way to make a method out of this?

foreach (KeyValuePair<int?, string> sourceVal in Source) {
            try {
                if (p.LeadOriginDetail != null) {
                    if (sourceVal.Value.ToUpper() == p.LeadOriginDetail.ToUpper()) {
                        sourceid = sourceVal.Key;
                        break;
                    } else {
                        sourceid = null;
                    }
                } else {
                    sourceid = null;
                }
            } catch (Exception ex) {
                CPCUtilities.LogGeneral("Error: " + ex.ToString());
            }
        }

Thanks!

Answer 1

If you would like to refactor it manually, try this:

int? Find(IEnumerable<KeyValuePair<int?, string>> items, string origin) {
    int? resId = null;
    foreach (KeyValuePair<int?, string> sourceVal in items) {
        try {
            if (origin != null) {
                if (sourceVal.Value.ToUpper() == origin.ToUpper()) {
                    resId = sourceVal.Key;
                    break;
                } else {
                    resId = null;
                }
            } else {
                resId = null;
            }
        } catch (Exception ex) {
            CPCUtilities.LogGeneral("Error: " + ex.ToString());
        }
    }
    return resId;
}

Now you can invoke this logic as follows:

var sourceId = Find(Source, p.LeadOriginDetail);
var marketId = Find(Market, p.LeadOriginDetail);
var businessUnitId = Find(BusinessUnit, p.LeadOriginDetail);

There is an easier way of getting the first matching ID using LINQ – it is nearly always a better choice than rolling your own loop, let alone making nine similar loops.