Question

I have an action sheet that is causing me grief on the iphone in Landscape orientation. Everything displays just fine, but in Landscape, the first real button has the same index as the cancel button and so the logic doesn’t work.

I’ve tried creating the actionSheet using initWithTitle: delegate: cancelButtonTitle: destructiveButtonTitle: otherButtonTitles: but that was just the same, my current code is as follows;

UIActionSheet* actionMenu = [[UIActionSheet alloc] init];

actionMenu.delegate = self;
actionMenu.title = folderentry.Name;
actionMenu.cancelButtonIndex = 0;

[actionMenu addButtonWithTitle:NSLocalizedString(@"str.menu.cancel",nil)];

[self addActiveButtons:actionMenu forEntry:folderentry];
[actionMenu showInView:[self.navigationController view]];
[actionMenu release];

The addActiveButtons method basically configures which buttons to add which it does using code like this;

[menu addButtonWithTitle:NSLocalizedString(@"str.menu.sendbyemail",nil)];

There are perhaps 6 buttons at times so in landscape mode the actionSheet gets displayed like this;

My delegate responds like this;

- (void)actionSheet:(UIActionSheet *)actionSheet clickedButtonAtIndex:(NSInteger)buttonIndex {

NSLog(@"Cancel Button Index is : %d",actionSheet.cancelButtonIndex);
NSLog(@"Button clicked was for index : %d",buttonIndex);

NSString *command = [actionSheet buttonTitleAtIndex:buttonIndex];

DLog(@"COMMAND IS: %@ for index: %d",command,buttonIndex);

if ([command isEqualToString:NSLocalizedString(@"str.menu.sendbyemail",nil)]) {

    // Do stuff here

}

if ( ... similar blocks ... ) { }

}

In the example shown, I am finding that cancelButtonIndex is 0 as expected, but so is the button index for the first other button! This means if I click on the second (Save to Photos) button for example, my debug output looks like this;

Cancel Button Index is : 0

Button clicked was for index : 1

COMMAND IS: Send by Email for index: 1

I’ve tried various permutations and am now tearing my hair out wondering what I’m missing. I’ve had a good search around but the other problems people seem to be having are display issues, rather than functionality ones.

Can anyone see where I’ve gone wrong?

PS. I know this isn’t the greatest UI experience, but I figure that most users will actually be in portrait most of the time or using the iPad version of the app so I’m prepared to accept the actionsheet default behaviour for landscape assuming I can get it to actually work!

Answer 1

OK, fixed it by counting how many buttons I was adding and then adding the cancel button as the last option, so my code looks like this;

int added = [self addActiveButtons:actionMenu forEntry:folderentry];

[actionMenu addButtonWithTitle:NSLocalizedString(@"str.menu.cancel",nil)];
actionMenu.cancelButtonIndex = added;

Hope that helps someone else struggling witht the same issue!