Question

I have an ad network script like the following

http://cdn.domain.com/ad.php?variables=etc

We have about 10,000 hits a second and we are looking at some improvements for our Pseudo code – this is what I have in mind – my question is – would PHP includes slow down my script like the if else codes and would it be worth minifying the PHP on this page:

<?php
// mysql connect
// get variables from publisher
// if publisher has no ads show advertise here banner 
// if resolution from variables is 125x125 show that banner or whatever resolution from the vars
// example www.noadhere.com/image/advertishere_{var}125px.jpg
// if publisher has no ads show advertise here banner and also updated mysql with page views for this publisher

// if publisher has a banner then show it and update mysql with page views
// show also the click code that redirects and updates the record with a hit click
?>

I have updated the code. This is the Phase 1 draft for those who are interested. I think it is so much simpler and I am going to minify this – even though there may not be need – we had 4 mysql actions happening. And now there are 3 – I just made the update views a one liner.

# mysql
$c=mysql_connect("sqlmaster.adserver.com","user","************");
mysql_select_db("adserver", $c);

# vars
$a=mysql_real_escape_string($_GET["z"]);//id
$z=mysql_real_escape_string($_GET["z"]);//zone
$h=mysql_real_escape_string($_GET["h"]);//height
$w=mysql_real_escape_string($_GET["w"]);//width
$d=date("Y-m-d H:i:s");//date
$u=mysql_real_escape_string($_SERVER['HTTP_REFERER']);//url

# constructor

    # do we have ads?
    $r1=mysql_query("");
    if(mysql_affected_rows()==0){

        # empty ad code unit
        echo 'Blog Empty';

    } else {

        # we have ads - so show random click code
        echo 'Click here .php ? and redirect';

    }

    # update mysql view table for this ad unit - empty or filled
    $r2=mysql_query("");

# end constructor
mysql_close($c);

Any suggestions on improving this would be welcomed. I think the mysql_real_escape is slow.

Answer 1

Using include only slows down your script by the amount of time it takes your server to open the file, which is usually just a fraction of a second. So it wouldn’t drastically slow down your script execution.