Question

I have an application that reads a table from a database.

I issue an SQL query to get a result set, based on a unique string value I glean from the results, I use a case/switch statement to generate certain objects (they inherit TreeNode BTW). These created objects get shunted into a Dictionary object to be used later.

Whilst generating these objects I use some of the values from the result set to populate values in the object via the setters.

I query the Dictionary to return a particular object type and use it to populate a treeview. However it is not possible to populate 2 objects of the same type in a treeview from the Dictionary object (you get a runtime error – which escapes me at the moment, something to with referencing the same object). So what I have to do is use a memberwiseClone and implement IClonable to get around this.

Am I doing this right? Is there a better way – because I think this is causing my program to be real slow at this point. At the very least I think its a bit clunky – any advice from people who know more than me – greatly appreciated.

Answer 1

To add to @Brad, only populate the tree as needed. That means hooking into the expand event of the tree nodes. This is similar to how Windows Explorer functions when dealing with network shares.

There should be 1 TreeNode object per actual tree node in the tree – don’t try to reuse the things. You may either associate them with your data using the Tag property (this is the recommended method), or you can subclass the TreeNode itself (this is the Java method, but used less in .NET).

(The use of cloning methods is usually a hint that you’re either (a) doing something wrong, or (b) need to factor your domain model to separate mutable objects from immutable.)