Question

I have an editor that lets users add HTML that is stored in the database and rendered on a web page. Since this is untrusted input, I plan to use Microsoft.Security.Application.AntiXsSS.GetSafeHtmlFragment to sanitize the HTML.

• Should I santiize before saving to the database or before rendering the untrusted input into the webpage?
• Is there an advantage in including the AntiXSS source code in my project instead of just the DLL? (Maybe I can customize the white list?)
• Which class file should I look in for actual implementation of the GetSafeHtmlFragment

Answer 1

I disagree with the selected answer for two reasons

1. If you stored encoded data, you have to pick an encoder before you store. What happens if you have stored something as HTML but also want to push it out in another format, for example as a JSON response, or as part of an XML document? You now have a an HTML encoded format you must decode, then encode in the correct format.
2. What if we discover a bug in the encoders and push a new version out? Now, because you’re not encoding at the point of output all your old data may contain things that have been incorrectly encoded. You can encode again, but then you hit double encoding issues which can be painful to filter correctly.

Generally you encode at the point of output and treat any data coming from a data store as untrusted by default – after all, what if someone manages to edit your database directly or via SQL injection?