Question

I have an input on my index page:

<input type="button" name="goReplaceAll" value="Go" id="allReplaceGo" style="cursor:hand;" />

And an onclick call from jquery:

$(document).ready(function() {
        $('#allReplaceGo').click(replaceAll);
});
function replaceAll(){ alert('a'); }

When I click the button, nothing happens. When I instead use onclick=”replaceAll()” within the HTML, I get an error: Uncaught ReferenceError: replaceAll is not defined

I am unable to figure out a connection between these errors, or any possible cause.

The code is currently live at http://www.texturepacker.net

Edit: Looks like I get two different results in Firefox and Chrome, Chrome does nothing while Firefox alert(‘a’)’s once the page loads. Now I’m just plain confused?

Edit: Seemingly an unrelated syntax error later in my code was breaking the call. Now replaceAll() is called when the dom loads, my question is now why isn’t replaceAll() being launched onclick and instead once the dom loads, am I missing something obvious?

Answer 1

Look like a syntax error here…

Line 196 in you script file says

$(this).("src",tmpSrc);

It is supposed to be

$(this).attr("src",tmpSrc);

Fix that and it should be all fine..

Also on line 7

$('#allReplaceGo').live("click",replaceAll());

is supposed to be

$('#allReplaceGo').live("click",replaceAll);

Also as of version 1.7 .live() is deprecated. try using .on() instead