Question

I have an object that looks like this:

public class MyObject
{
    public int UserID {get;set;}
    public List<SomeObjects> {get;set;}
    public List<SomeOtherObjects {get;set}
    public MyObject TheObjectForDB {get;set} //HERE: creating a new object

    public MyObject(int TheUserID)
    {
        this.UserID = TheUserID;
    }

    public LoadTheObjectFromDatabase()
    {
        MyQueries TheQueries = new MyQueries();
        TheObjectForDB = TheQueries.LoadFromDB(UserID) //HERE: object for DB work

        this.List<SomeObjects> = TheObjectForDB.List<SomeObjects>;
        this.List<SomeOtherObjects> = TheObjectForDB.List<SomeOtherObjects>;
    }
}

The database query essentially returns the same object type:

LoadFromDB = from...
             select new MyObject(TheUserID){...}

How can I remove this redundancy where I need to instantiate another object of the same type to populate the initial object?

Thanks for your suggestions.

Answer 1

Make LoadTheObjectFromDatabase() a static method which returns a new MyObject.

public class MyObject
{
    public int UserID {get;set;}
    public List<SomeObjects> {get;set;}
    public List<SomeOtherObjects {get;set}

    public MyObject(int TheUserID)
    {
        this.UserID = TheUserID;
    }

    public static MyObject LoadTheObjectFromDatabase(int userid)
    {
        MyQueries TheQueries = new MyQueries();
        MyObject TheObjectForDB = TheQueries.LoadFromDB(userid) //HERE: object for DB work

        return TheObjectForDB;
    }
}

Then, instead of doing MyObject newObj = new MyObject(); newObj.LoadTheObjectFromDatabase();, you’d just do MyObject newObj = MyObject.LoadTheObjectFromDatabase();