Question

I have been a follower for a long time but this is the first time I ask a question. In a nutshell, the issue is; vector<Student*> studentvector that is a vector of object pointers seems to push the student info back as student ; but when I print to see the first one in vector whether it performs as intended, I see it always updates the first record with new coming student info although there is no problem on studentvector.size() It pushes the record back to the vector as many as how many time I call addStudent(...) but it fills all vector with the information of last student. What may be done to succeed in filling vector with correct info within this frame, without using smart pointers or advanced stuff?

Sorry if I am vague on my question. You may lead me to provide what is also necessary to understand the problem. Thanks in advance.

addStudent(const string alias, const string name) throw(StudentException)
{
Student* student = new Student(alias, name)
studentvector.push_back(student);
cout << studentvector.front() << endl;
}

That is the implementation of Student;

#include "Student.h"

string *Alias;
string *Name;


Student::Student(string alias)
{
    Alias = new string(alias);
}

Student::Student(string alias, string name)
{
    Alias = new string(alias);
    Name = new string(name);
}

Student::~Student()
{
    delete Alias;
    delete Name;
}

const string& Student::getAlias() const
{
    return *Alias;
}

void Student::setAlias(const string& alias)
{
    *Alias = alias;
}

const string& Student::getName() const
{
    return *Name;
}

void Student::setName(const string& name)
{
    *Name = name;
}

Consider alias is not reserved.

Answer 1

Doh! Here’s your problem – all objects from type Student use the same global pointers:

string *Alias;
string *Name;

Make these two as members in you class

class Student
{
private:
    string *Alias;
    string *Name;
//..
}; 

---

EDIT:
Also, I don't think, that it's a good idea to use pointer to std::string, I'd suggest you to use like this:

class Student
{
private:
    string Alias;
    string Name;
//..
};