Home/ Questions/Q 154261
In Process

The Archive Base Latest Questions

Editorial Team
  • 0
Asked: 2026-05-11T09:56:51+00:00

I have been using this method to filter my queries: Create PROCEDURE [dbo].[pGetTask] @showCompletedTasks

  • 0

I have been using this method to filter my queries:

Create PROCEDURE [dbo].[pGetTask]     @showCompletedTasks bit = 1     ,@showInProgressTasks bit = 1     ,@taskID int = null     ,@projectID int = null     ,@applicationID int = null     ,@clientID int = null  ... Snip ...  where            a.clientID = isnull(@clientID, a.clientID)     and a.applicationID = isnull(@applicationID, a.applicationID)     and p.projectID = isnull(@projectID, p.projectID)     and t.taskID = isnull(@taskID, t.taskID)     and curr.complete = case @showCompletedTasks when 0 then 0 else curr.complete end     and curr.complete = case @showInProgressTasks when 0 then 1 else curr.complete end

This actually slows my queries by 2 seconds on a 664 row result set. The SQL tuning advisor isn’t much help, so I figure this is not the right way to do this. Is there a right way, besides a ton of if statements?

Share

Leave an answer

You must login to add an answer.

Need An Account,

1 Answer

  1. Assuming you have properly indexed the table that the select is on, and these fields are part of the index, my guess is that it would be the calls to isnull. I would change them to this:

    (@clientID is null or a.clientID = @clientId) and ...

    As for the case statements, indexes on bit fields are pointless, so there’s not much to do there.

    • 0