Question

I have code that looks like this:

var baseClass = function() {
// CODE
    var subClass = function() {
        // MORE CODE
    }
}

Adding methods to baseClass is fine, I just use

baseClass.prototype.newMethod = function () {
    // NEW CODE
}

My question is how should I add methods to subClass? Is the only way to simply make it a public method?

######## EDIT ##############

OK so I’ve rearranged the code so the subClass is outside the baseClass. I pass in baseClass so subClass can still access the properties of the instance of baseClass.

var baseClass = function() {
    var base = this;
    this.property_a = 1;
    this.property_b = 5;

    var sub = new subClass(base);
    // CODE
}

var subClass = function(parent) {
    var sub = this;
    this.property_c = 1;
    this.method_a = function() {
        return sub.property_c + parent.property_a;
    }
    // MORE CODE
}

this is fine and works, but now I have a new problem of when I add a method using prototype:

subClass.prototype.method_b = function(){
    return sub.property_c + parent.property_b;
}

I get an error saying parent isn’t defined.

Basically I have a fairly simple web application that has two sides, a viewing side and an editing side. I build the base class which includes everything necessary for viewing, and I want to add the methods required for editing in a different file so they’re only loaded when a user is on the editing page.

Answer 1

Why do you declare that subclass in the base class? Doesn’t make sense to me.

You can add to the subclass’s prototype whereever it is in you scope. In your code it would be

var baseClass = function() {
// CODE
    var subClass = function() {
        // MORE CODE
    }
    subClass.prototype = {
        ...
    }
}

But I’d suggest to put it out of the base class constructor. If you want it private for some reason, add a closure:

(function(){

    baseClass = function() { // public
        // CODE
    }
    baseClass.prototype = {...};

    var subClass = function() { // private
        // MORE CODE
    }
    subClass.prototype = Object.create(baseClass.prototype);
    subClass.prototype.newMethod = function () { ... }
})()

---

EDIT to answer the extended question:

Ah, subClass doesn’t inherit from baseClass! We had expected that, otherwise it may be OK to have it inside the constructor. Then, the same prototype could have been added to each of the different subClass constructors:

var subproto = {
    method_b: = function(){
        // manipulate "this"
    },
    ...
};
function baseClass() {
    // some code
    function sub() {
        // is a constructor for subs which belong to this specif base intance
        ...
    }
    sub.prototype = subproto; // the sub constructors of each base instance
                              // have the same prototype
    var x = new sub(),
        y = new sub(); // example usage of the sub constructor
}
baseClass.prototype = {...}

Else, if you want one common sub constructor (outside of function baseClass), you may give the base instance the sub belongs to as an argument to the constructor – as you did. Of course the sub (both internal and external methods) can only access public properties of that base instance.

The mistake you made in your rearranged code is that your prototype (“external”) methods tried to access the private parent variable from the sub constructor. As you say, “error saying parent isn’t defined”.

var subClass = function(parent) {
    var sub = this;
    this.parent = parent; // make it public
    this.property_c = 1;
    this.method_a = function() {
        return sub.property_c + parent.property_a;
    }
    // MORE CODE
}
subClass.prototype.method_b = function(){
    // prototype functions can only access public properties
    // i.e. privileged methods, public attributes and other prototype properties
    return this.property_c + this.parent.property_b;
}