Question

I have created a function that takes a SQL command and produces output that can then be used to fill a List of class instances. The code works great. I’ve included a slightly simplified version without exception handling here just for reference – skip this code if you want to jump right the problem. If you have suggestions here, though, I’m all ears.

    public List<T> ReturnList<T>() where T : new()     {         List<T> fdList = new List<T>();         myCommand.CommandText = QueryString;         SqlDataReader nwReader = myCommand.ExecuteReader();         Type objectType = typeof (T);         FieldInfo[] typeFields = objectType.GetFields();         while (nwReader.Read())         {             T obj = new T();             foreach (FieldInfo info in typeFields)             {                 for (int i = 0; i < nwReader.FieldCount; i++)                 {                     if (info.Name == nwReader.GetName(i))                     {                         info.SetValue(obj, nwReader[i]);                         break;                     }                 }             }             fdList.Add(obj);         }         nwReader.Close();         return fdList;     } 

As I say, this works just fine. However, I’d like to be able to call a similar function with an anonymous class for obvious reasons.

Question #1: it appears that I must construct an anonymous class instance in my call to my anonymous version of this function – is this right? An example call is:

.ReturnList(new { ClientID = 1, FirstName = '', LastName = '', Birthdate = DateTime.Today }); 

Question #2: the anonymous version of my ReturnList function is below. Can anyone tell me why the call to info.SetValue simply does nothing? It doesn’t return an error or anything but neither does it change the value of the target field.

    public List<T> ReturnList<T>(T sample)      {         List<T> fdList = new List<T>();         myCommand.CommandText = QueryString;         SqlDataReader nwReader = myCommand.ExecuteReader();         // Cannot use FieldInfo[] on the type - it finds no fields.         var properties = TypeDescriptor.GetProperties(sample);          while (nwReader.Read())         {             // No way to create a constructor so this call creates the object without calling a ctor. Could this be a source of the problem?             T obj = (T)FormatterServices.GetUninitializedObject(typeof(T));              foreach (PropertyDescriptor info in properties)               {                 for (int i = 0; i < nwReader.FieldCount; i++)                 {                     if (info.Name == nwReader.GetName(i))                     {                         // This loop runs fine but there is no change to obj!!                         info.SetValue(obj, nwReader[i]);                         break;                     }                 }             }             fdList.Add(obj);         }         nwReader.Close();         return fdList;     } 

Any ideas?

Note: when I tried to use the FieldInfo array as I did in the function above, the typeFields array had zero elements (even though the objectType shows the field names – strange). Thus, I use TypeDescriptor.GetProperties instead.

Any other tips and guidance on the use of reflection or anonymous classes are appropriate here – I’m relatively new to this specific nook of the C# language.

UPDATE: I have to thank Jason for the key to solving this. Below is the revised code that will create a list of anonymous class instances, filling the fields of each instance from a query.

   public List<T> ReturnList<T>(T sample)    {        List<T> fdList = new List<T>();        myCommand.CommandText = QueryString;        SqlDataReader nwReader = myCommand.ExecuteReader();        var properties = TypeDescriptor.GetProperties(sample);        while (nwReader.Read())        {            int objIdx = 0;            object[] objArray = new object[properties.Count];            foreach (PropertyDescriptor info in properties)                 objArray[objIdx++] = nwReader[info.Name];            fdList.Add((T)Activator.CreateInstance(sample.GetType(), objArray));        }        nwReader.Close();        return fdList;    } 

Note that the query has been constructed and the parameters initialized in previous calls to this object’s methods. The original code had an inner/outer loop combination so that the user could have fields in their anonymous class that didn’t match a field. However, in order to simplify the design, I’ve decided not to permit this and have instead adopted the db field access recommended by Jason. Also, thanks to Dave Markle as well for helping me understand more about the tradeoffs in using Activator.CreateObject() versus GenUninitializedObject.

Answer 1

Anonymous types encapsulate a set of read-only properties. This explains

1. Why Type.GetFields returns an empty array when called on your anonymous type: anonymous types do not have public fields.

2. The public properties on an anonymous type are read-only and can not have their value set by a call to PropertyInfo.SetValue. If you call PropertyInfo.GetSetMethod on a property in an anonymous type, you will receive back null.

In fact, if you change

var properties = TypeDescriptor.GetProperties(sample); while (nwReader.Read()) {     // No way to create a constructor so this call creates the object without calling a ctor. Could this be a source of the problem?     T obj = (T)FormatterServices.GetUninitializedObject(typeof(T));      foreach (PropertyDescriptor info in properties) {         for (int i = 0; i < nwReader.FieldCount; i++) {             if (info.Name == nwReader.GetName(i)) {                 // This loop runs fine but there is no change to obj!!                 info.SetValue(obj, nwReader[i]);                 break;             }         }     }     fdList.Add(obj); } 

to

PropertyInfo[] properties = sample.GetType().GetProperties(); while (nwReader.Read()) {     // No way to create a constructor so this call creates the object without calling a ctor. Could this be a source of the problem?     T obj = (T)FormatterServices.GetUninitializedObject(typeof(T));     foreach (PropertyInfo info in properties) {         for (int i = 0; i < nwReader.FieldCount; i++) {             if (info.Name == nwReader.GetName(i)) {                 // This loop will throw an exception as PropertyInfo.GetSetMethod fails                 info.SetValue(obj, nwReader[i], null);                 break;             }         }     }     fdList.Add(obj); } 

you will receive an exception informing you that the property set method can not be found.

Now, to solve your problem, what you can do is use Activator.CreateInstance. I’m sorry that I’m too lazy to type out the code for you, but the following will demonstrate how to use it.

var car = new { Make = 'Honda', Model = 'Civic', Year = 2008 }; var anothercar = Activator.CreateInstance(car.GetType(), new object[] { 'Ford', 'Focus', 2005 }); 

So just run through a loop, as you’ve done, to fill up the object array that you need to pass to Activator.CreateInstance and then call Activator.CreateInstance when the loop is done. Property order is important here as two anonymous types are the same if and only if they have the same number of properties with the same type and same name in the same order.

For more, see the MSDN page on anonymous types.

Lastly, and this is really an aside and not germane to your question, but the following code

foreach (PropertyDescriptor info in properties) {     for (int i = 0; i < nwReader.FieldCount; i++) {         if (info.Name == nwReader.GetName(i)) {             // This loop runs fine but there is no change to obj!!             info.SetValue(obj, nwReader[i]);             break;         }     } } 

could be simplified by

foreach (PropertyDescriptor info in properties) {             info.SetValue(obj, nwReader[info.Name]); }