Question

I have created a simple PHP login system, I am fairly new to PHP in some ways. The login system doesn’t use a database as its only one user.

<?php
if(isset($_SESSION['loggedin']))
{
 die("You are already logged in!");
}
if(isset($_POST['submit']))
{
if ($_POST["Username"]=="****" && $_POST["password"]=="****")
{
$_SESSION['loggedin'] = "1";
print $_SESSION['loggedin'];
} 
}
?>

Then for every other page I have a PHP checker with an if statement:

<?php
session_start(); // NEVER forget this!
if(!isset($_SESSION['loggedin'] = "1"))
{
die("To access this page, you need to <a href='login.php'>LOGIN</a>");
} 
?>

It worked when I just set loggedin to ‘YES’ and then used the line

if(!isset($_SESSION['loggedin']))

But when I try to assign loggedin a number in this example 1, and then make the checker check that if its NOT the number 1 then die, like this:

if(!isset($_SESSION['loggedin'] = "1"))

it doesn’t work. Can anyone tell me how I am going wrong?

Answer 1

Try using == instead of =. Using ‘=’ will assign the value 1 to the session variable.

if(!isset($_SESSION['loggedin'] == "1"))

However, a better option would be:

if($_SESSION['loggedin'] != "1")

Using Yoda conditions and checking whether $_SESSION[‘loggedin’] is set, that would be:

if(!isset($_SESSION['loggedin']) || "1" != $_SESSION['loggedin'])