Question

I have created an asp.net application using Entity Framework. In this I want to add the records into a list. For this I have to use the foreach loop but it always adding only last record data for all records, meaning it’s showing same data. Here I have pasted my code. Please verify it once and guide where I can change.

     public List<CategoryItems> ListMenuCategory(int MenuId)
    {
        string str = string.Empty;
        string strJSON = string.Empty;
        List<CategoryItems> resultmenu;
        resultmenu = new List<CategoryItems>();
        List<CategoryItems> Result;
        Result = new List<CategoryItems>();
        bool check = true;
        var objmenuCategory = from cat in objEntity.menucategories where cat.MenuId == MenuId && cat.Active == check select cat;
        CategoryItems Categorylist = new CategoryItems();
        foreach (menucategory category in objmenuCategory)
        {
            Categorylist.CategoryName = category.CategoryName;
            Categorylist.Description = category.Description;
            int menuid = category.MenuCategoryId;
            List<menuitem> menuitems = GetMenucategories(menuid);
            foreach (var items in menuitems)
            {
                Categorylist.ItemName = items.ItemName;
                Categorylist.Description = items.Description;
                Categorylist.Price = (float)items.Price;
                string Image = items.Picture;
                Categorylist.Picture = "http://restaurantmanager.testshell.net/Images/" + Image;
                Categorylist.Thumbnail = "http://restaurantmanager.testshell.net/Images/" + items.Thumbnail;
                if (items.CreatedDate != null)
                {
                    Categorylist.CreatedDate = (DateTime)items.CreatedDate;
                }

                if (items.ModifiedDate != null)
                {
                    Categorylist.ModifiedDate = (DateTime)items.ModifiedDate;
                }
                Result.Add(Categorylist);

            }


            // Result.AddRange(menus);


        }
        return Result;



        }


    private List<menuitem> GetMenucategories(int p)
       {
        restaurantEntities objEntity1 = new restaurantEntities();
         var menuitems = from items in objEntity1.menuitems where items.MenuCategoryId == p select items;
   return menuitems.ToList();
     }

Answer 1

You are creating the Categorylist item outside of the loops, so you are only using one single item, filling it with different data and adding it over and over to the result.

You have to create the item inside the innermost loop, so that each iteration gets its own object.

---

Note: ChrisF also spotted that you call AddRange inside the loop, which has the result that you will add the same set of items over and over. You don’t need to call AddRange at all, you can just skip the Result list entirely and just return resultmenu instead.