Question

I have declared a local string inside the method. I am releasing the string inside the same method. I found my code crashing if release that object. If I don’t release the string, code runs successfully.

I have called that method in viewdidappear so that method is called while pushing and poping. Nothing gets printed in the console. Here is my code

-(void)appendString{
NSString  *locStr = [[NSString alloc] initWithString:@""];
for (int i=0;i<[result count]; i++)
{   
locStr=[locStr stringByAppendingFormat:@"%@",[result objectAtIndex:i]];
}
[str setString:locStr];
[locStr release];
}

I am calling the “appendString” method from “viewDidAppear”.”str” is a NSMutable string declared in .h class.How should I release the “locStr”.

What went wrong in my code? This isn’t the normal way to release it?

Answer 1

Try this:

-(void)appendString{
//stringWithString returns an autorelease object
//so you don't need to worry about its memory management
NSString  *locStr = [NSString stringWithString:@""];
for (int i=0;i<[result count]; i++)
{   
//if your locstr is created by initWithString instead,
//the following line is going to cause memory leak
locStr=[locStr stringByAppendingFormat:@"%@",[result objectAtIndex:i]];
}
[str setString:locStr];
//[locStr release];
}

And make sure that the string property in your str instance is set to retain