Question

I have declared NSString with some string value in ViewdidLoad like..

int i=1;
strval=[NSString stringWithFormat:@"%03d",i];
strval=[NSString stringWithFormat:@"S%@",strval];

NSLog(@"Value %@",strval);

it gives correct result as S001, but when i print this same in IBAction like,

- (IBAction)stringvalue:(id)sender {
NSLog(@"Value %@",strval);
}

it gives unknown values each time.Sometimes it throws EXEC_BAD_ACCESS error.

Please help me..

Answer 1

Looks like you aren’t using ARC, so the string is being released the next time the autorelease pool drains. You need to explicitly retain it in viewDidLoad and explicitly release it in your overwridden dealloc method:

- (void)viewDidLoad
{
    ...

    strval = [[NSString stringWithFormat:@"%03d", i] retain];

    ....
}

- (void)dealloc
{
    [strval release];

    ...

    [super dealloc];
}

(I am assuming you’ve actually declared strval as an instance method).