Question

I have difficulties to apply this if statement in my nginx config:

location / {
    break;
    proxy_pass                  http://127.0.0.1:4444;
    proxy_redirect              off;
    proxy_set_header            Host                        $host;
    proxy_set_header            X-Real-IP               $remote_addr;
    proxy_set_header            X-Forwarded-For         $proxy_add_x_forwarded_for;

    if ($arg_charset ~* windows-1251) {
        charset                     windows-1251;
    }
    source_charset              utf-8;
}

I have tried $arg_charset ~* “windows-1251” and $arg_charset ~* /.windows-1251./ and all others solutions. None does work…
Removing if statements give me wanted results, so the problem is inside if statement condition.

It’s a bug or i’m doing it wrong?

Answer 1

As http://wiki.nginx.org/IfIsEvil explains, if blocks inside a location are known to be potentially problematic when they contain anything other then a return or rewrite

try simply moving the if into the server block directly (where if has no problems) that should fix it.

updated to avoid using charset directive in serverblock:

try something like the following:

set $requestedcharset utf-8;
if ($arg_charset ~* windows-1251) { set $requestedcharset windows-1251;}

location / {
  source_charset utf-8;
  charset $requestedcharset;
  #add in the rest of your / config
}

NOTE: make sure you have the win-utf charset_map included in your http block (on my debian system that means include /etc/nginx/win-utf;)