Question

I have extended the devise controller for sessions. To add some extra functionality when a user logs in. Now upon login, IF no username or password are entered I get error :
SessionsController#create

Called id for nil, which would mistakenly be 4 — if you really wanted the id of nil, use object_id

I searched last week for up to 2 hours how to fix this anyone can help me out on this one? Would be highly appreciated

How to correctly add my custom functionality but still preserve the Devise create action?

class SessionsController < Devise::SessionsController

  def create

    @user = User.where(:id => current_user.id).first
    @moderated = Asset.where(:attachable_id => current_user.id, :moderated => true).first

    if @user.sign_in_count.to_i == 1
      def after_sign_in_path_for(resource)
        "/welcome/basics"
      end
    else
      if @moderated.nil?
        unless @user.has_photo?
          def after_sign_in_path_for(resource)
          "/home/no_photo"
          end
        end
      else
        def after_sign_in_path_for(resource)
          "/home/moderated"
        end
      end
    end
  end
end

Answer 1

If your additional functionality consists of redirecting the user to a different page at his first login i would suggest defining after_sign_in_path_for in the application controller as suggested by the wiki.

class ApplicationController < ActionController::Base

  private

  def after_sign_in_path_for(resource)
    if current_user.sign_in_count == 1
      "/welcome/basics"
    else
      "/other/path"
    end
  end

end

Please note that this only works if User is the only resource that can sign into your application. Otherwise you would have to differentiate in this method as well via the resource parameter.