Question

I have found two ways. Which one is better? Is there any other way better than these two?

 myArray.splice($.inArray(id, myArray),1);

or

myArray.splice(myArray.indexOf(id),1);

Answer 1

Neither option is safe because both will remove the last element from the array if id isn’t found.

Whether you use $.inArray() or .indexOf() you’ll get a return of -1 if id isn’t in the array, and when you pass -1 to the .splice() method it will remove the last item from the array.

So really you should say:

var index = $.inArray(id, myArray); // or myArray.indexOf(id)
if (index > -1) myArray.splice(index, 1);

Obviously you can encapsulate the above in a function of your own if desired.

As for which of $.inArray() and .indexOf() is better, that depends on whether you care about supporting older browsers (mainly IE8 and less) that don’t support .indexOf(). You should care if your code is on a public website, since a lot of people still use IE8 and IE7. If you’re already using jQuery you might as well stick with $.inArray(), otherwise use the .indexOf() shim at MDN.