Question

I have huge store procedure. I only paste small part of this.

My Query:

--declare variable and Select Statement goes here
WHERE  ((v.[RoleID] IN (
         SELECT [dbo].[aspnet_UsersInRoles].roleid 
         FROM [dbo].[aspnet_UsersInRoles] 
         INNER JOIN [dbo].[aspnet_Users] 
           ON [dbo].[aspnet_Users].userid = [dbo].[aspnet_UsersInRoles].userid 
         WHERE 
           [dbo].[aspnet_Users].username = @UserName 
         UNION ALL 
         SELECT [RoleId] 
         FROM   dbo.aspnet_roles 
         WHERE loweredrolename = 'anonymous user') 
OR v.username = @UserName)) 

Query works perfect but its take long time to execute. There is so many condition inside WHERE condition with IN. I think the subquery inside IN take time. Is there any way to optimize this query and replace IN inside WHERE condition. Or suggest me an alternative way to optimize this type of query. Thanks.

Answer 1

Since the output of inner subquery is always the same. You can take that outside and insert those values into a temptable like below and u could just query to the temp table. So each time it doesnt go in a loop executing the same

  `create table #temp(roleid int); `

  ` insert into #temp as (sSELECT [dbo].[aspnet_UsersInRoles].roleid 
     FROM [dbo].[aspnet_UsersInRoles] 
     INNER JOIN [dbo].[aspnet_Users] 
       ON [dbo].[aspnet_Users].userid = [dbo].[aspnet_UsersInRoles].userid 
     WHERE 
       [dbo].[aspnet_Users].username = @UserName 
     UNION ALL 
     SELECT [RoleId] 
     FROM   dbo.aspnet_roles 
     WHERE loweredrolename = 'anonymous user');`

    WHERE  ((v.[RoleID] IN ( select roleid from #temp);