Question

I have my 2nd assignment for C++ class which includes Markov chains. The assignment is simple but I’m not able to figure out what is the best implementation when reading chars from files.

I have a file around 300k. One of the rules for the assignment is to use Map and Vector classes. In Map (key is only string) and values will be the Vectors. When I’m reading from the file, I need to start collecting key pairs.

Example:

File1.txt
1234567890
1234567890

If Select Markov k=3, I should have in my Map:

key     vector
123  -> 4
456  -> 7
789  -> 0
0/n1 -> 2
234  -> 5
567  -> 8
890  -> /n
/n   -> NULL

The professor’s suggestion is to read char by char, so my algorithm is the following

while (readchar != EOF){
tempstring += readchar
increment index
if index == Markovlevel {   
       get nextchar if =!EOF
       insert nextchar value in vector
       insert tempstring to Map and assign vector         
       unget char
}

}

I omit some other details. My main question is that if I have 318,000 characters, I will be doing the conditional every time which slows down my computer a lot (brand new MAC pro). A sample program from the professor executes this file in around 5 seconds.

I’m not able to figure out what’s the best method to read fixed length words from a text file in C++.

Thanks!

Answer 1

Have you actually timed the program? 318,000 conditionals should be a piece of cake for your brand new MAC pro. That should take only microseconds.

Premature optimization is the root of all evil. Make your program work first, optimization comes second.